Merge pull request #197 from GSA/dev-infra-setup

Add scripts for provisioning development credentials

tests/app/aws/test_s3.py

@@ -3,9 +3,9 @@ from os import getenv
 
 from app.aws.s3 import get_s3_file
 
-default_access_key = getenv('AWS_ACCESS_KEY_ID')
-default_secret_key = getenv('AWS_SECRET_ACCESS_KEY')
-default_region = getenv('AWS_REGION')
+default_access_key = getenv('CSV_AWS_ACCESS_KEY_ID')
+default_secret_key = getenv('CSV_AWS_SECRET_ACCESS_KEY')
+default_region = getenv('CSV_AWS_REGION')
 
 
 def single_s3_object_stub(key='foo', last_modified=None):

tests/app/clients/test_aws_sns.py

@@ -15,7 +15,7 @@ def test_send_sms_successful_returns_aws_sns_response(notify_api, mocker):
         Message=content,
         MessageAttributes={
             'AWS.SNS.SMS.SMSType': {'DataType': 'String', 'StringValue': 'Transactional'},
-            'AWS.MM.SMS.OriginationNumber': {'DataType': 'String', 'StringValue': '+18446120782'}
+            'AWS.MM.SMS.OriginationNumber': {'DataType': 'String', 'StringValue': '+18556438890'}
         }
     )
 

tests/app/delivery/test_send_to_providers.py

@@ -11,6 +11,7 @@ from requests import HTTPError
 
 import app
 from app import aws_sns_client, notification_provider_clients
+from app.cloudfoundry_config import cloud_config
 from app.dao import notifications_dao
 from app.dao.provider_details_dao import get_provider_details_by_identifier
 from app.delivery import send_to_providers
@@ -164,7 +165,7 @@ def test_should_send_personalised_template_to_correct_email_provider_and_persist
     )
 
     app.aws_ses_client.send_email.assert_called_once_with(
-        '"Sample service" <sample.service@notify.sandbox.10x.gsa.gov>',
+        f"\"Sample service\" <sample.service@{cloud_config.ses_email_domain}>",
         'jo.smith@example.com',
         'Jo <em>some HTML</em>',
         body='Hello Jo\nThis is an email from GOV.\u200bUK with <em>some HTML</em>\n',