darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improved test to include check on log

Browse Source
This commit is contained in:
Ken Tsang
2017-07-04 11:16:16 +01:00
committed by venusbb
parent f028dab252
commit 5efe4d59ec
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
tests/app/notifications/test_receive_notification.py
View File

@@ -5,6 +5,7 @@ from unittest.mock import call
import pytest import pytest
from flask import json from flask import json
from app.dao.services_dao import dao_fetch_services_by_sms_sender
from app.notifications.receive_notifications import ( from app.notifications.receive_notifications import (
format_mmg_message, format_mmg_message,
format_mmg_datetime, format_mmg_datetime,
@@ -17,18 +18,17 @@ from tests.app.db import create_service
from tests.app.conftest import sample_service from tests.app.conftest import sample_service
def test_receive_notification_returns_received_to_mmg( def test_receive_notification_returns_received_to_mmg(client, mocker, sample_service_full_permissions):
client, mocker, sample_service_full_permissions):
mocked = mocker.patch("app.notifications.receive_notifications.tasks.send_inbound_sms_to_service.apply_async") mocked = mocker.patch("app.notifications.receive_notifications.tasks.send_inbound_sms_to_service.apply_async")
data = { data = {
"ID": "1234", "ID": "1234",
"MSISDN": "447700900855", "MSISDN": "447700900855",
"Message": "Some message to notify", "Message": "Some message to notify",
"Trigger": "Trigger?", "Trigger": "Trigger?",
"Number": "testing", "Number": "testing",
"Channel": "SMS", "Channel": "SMS",
"DateRecieved": "2012-06-27 12:33:00" "DateRecieved": "2012-06-27 12:33:00"
} }
response = client.post(path='/notifications/sms/receive/mmg', response = client.post(path='/notifications/sms/receive/mmg',
data=json.dumps(data), data=json.dumps(data),
headers=[('Content-Type', 'application/json')]) headers=[('Content-Type', 'application/json')])
@@ -62,7 +62,7 @@ def test_receive_notification_returns_received_to_mmg(
"Message": "Some message to notify", "Message": "Some message to notify",
"source": "Source", "source": "Source",
"time": "2012-06-27 12:33:00", "time": "2012-06-27 12:33:00",
"destination": "447700900856" "destination": "447700900855"
}, },
'{\n "status": "ok"\n}' '{\n "status": "ok"\n}'
), ),
@@ -74,7 +74,11 @@ def test_receive_notification_returns_received_to_mmg(
def test_receive_notification_without_permissions_does_not_create_inbound( def test_receive_notification_without_permissions_does_not_create_inbound(
client, mocker, notify_db, notify_db_session, permissions, provider, headers, data, expected_response): client, mocker, notify_db, notify_db_session, permissions, provider, headers, data, expected_response):
service = sample_service(notify_db, notify_db_session, permissions=permissions) service = sample_service(notify_db, notify_db_session, permissions=permissions)
mocker.patch("app.notifications.receive_notifications.dao_fetch_services_by_sms_sender",
return_value=[service])
mocked = mocker.patch("app.notifications.receive_notifications.tasks.send_inbound_sms_to_service.apply_async") mocked = mocker.patch("app.notifications.receive_notifications.tasks.send_inbound_sms_to_service.apply_async")
mocked_logger = mocker.patch("flask.current_app.logger.error")
response = client.post(path='/notifications/sms/receive/{}'.format(provider), response = client.post(path='/notifications/sms/receive/{}'.format(provider),
data=data, data=data,
headers=headers) headers=headers)
@@ -83,6 +87,7 @@ def test_receive_notification_without_permissions_does_not_create_inbound(
assert response.get_data(as_text=True) == expected_response assert response.get_data(as_text=True) == expected_response
assert len(InboundSms.query.all()) == 0 assert len(InboundSms.query.all()) == 0
assert mocked.called is False assert mocked.called is False
assert mocked_logger.call_args == call('Service "{}" does not allow inbound SMS'.format(service.id))
@pytest.mark.parametrize('message, expected_output', [ @pytest.mark.parametrize('message, expected_output', [