darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 15:29:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3469 from alphagov/free-allowance-0

Browse Source 
Allow SMS fragment limit to be 0
This commit is contained in:
Katie Smith
2022-02-28 14:10:44 +00:00
committed by GitHub
parent b56906bc43 c9dafa0372
commit 5ef9198869
4 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/billing/billing_schemas.py
View File

@@ -6,7 +6,7 @@ create_or_update_free_sms_fragment_limit_schema = {
"type": "object", "type": "object",
"title": "Create", "title": "Create",
"properties": { "properties": {
"free_sms_fragment_limit": {"type": "integer", "minimum": 1}, "free_sms_fragment_limit": {"type": "integer", "minimum": 0},
}, },
"required": ["free_sms_fragment_limit"] "required": ["free_sms_fragment_limit"]
} }

4
tests/app/billing/test_billing.py
View File

@@ -29,10 +29,6 @@ IN_MAY_2016 = datetime(2016, 5, 10, 23, 00, 00)
IN_JUN_2016 = datetime(2016, 6, 3, 23, 00, 00) IN_JUN_2016 = datetime(2016, 6, 3, 23, 00, 00)
def _assert_dict_equals(actual, expected_dict):
assert actual == expected_dict
def test_create_update_free_sms_fragment_limit_invalid_schema(client, sample_service): def test_create_update_free_sms_fragment_limit_invalid_schema(client, sample_service):
response = client.post('service/{}/billing/free-sms-fragment-limit'.format(sample_service.id), response = client.post('service/{}/billing/free-sms-fragment-limit'.format(sample_service.id),

1
tests/app/db.py
View File

@@ -260,7 +260,6 @@ def create_notification(
rate_multiplier=None, rate_multiplier=None,
international=False, international=False,
phone_prefix=None, phone_prefix=None,
scheduled_for=None,
normalised_to=None, normalised_to=None,
one_off=False, one_off=False,
reply_to_text=None, reply_to_text=None,

2
tests/app/v2/notifications/test_get_notifications.py
View File

@@ -20,7 +20,6 @@ def test_get_notification_by_id_returns_200(
template=sample_template, template=sample_template,
billable_units=billable_units, billable_units=billable_units,
sent_by=provider, sent_by=provider,
scheduled_for="2017-05-12 15:15"
) )
# another # another
@@ -28,7 +27,6 @@ def test_get_notification_by_id_returns_200(
template=sample_template, template=sample_template,
billable_units=billable_units, billable_units=billable_units,
sent_by=provider, sent_by=provider,
scheduled_for="2017-06-12 15:15"
) )
auth_header = create_service_authorization_header(service_id=sample_notification.service_id) auth_header = create_service_authorization_header(service_id=sample_notification.service_id)