darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 08:21:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removed DELIVERY_CLIENT_USER_NAME and DELIVERY_CLIENT_SECRET from configs and auth module

Browse Source
This commit is contained in:
Rebecca Law
2016-03-08 15:27:12 +00:00
parent e99331315e
commit 5d7b1bc786
4 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -26,8 +26,6 @@ export ADMIN_CLIENT_SECRET='dev-notify-secret-key'
export ADMIN_CLIENT_USER_NAME='dev-notify-admin' export ADMIN_CLIENT_USER_NAME='dev-notify-admin'
export AWS_REGION='eu-west-1' export AWS_REGION='eu-west-1'
export DANGEROUS_SALT='dev-notify-salt' export DANGEROUS_SALT='dev-notify-salt'
export DELIVERY_CLIENT_USER_NAME='dev-notify-delivery'
export DELIVERY_CLIENT_SECRET='dev-notify-secret-key'
export FIRETEXT_API_KEY=[contact team member for api key] export FIRETEXT_API_KEY=[contact team member for api key]
export FIRETEXT_NUMBER="Firetext" export FIRETEXT_NUMBER="Firetext"
export INVITATION_EMAIL_FROM='invites@notifications.service.gov.uk' export INVITATION_EMAIL_FROM='invites@notifications.service.gov.uk'

5
app/authentication/auth.py
View File

@@ -61,11 +61,6 @@ def fetch_client(client):
"client": client, "client": client,
"secret": [current_app.config.get('ADMIN_CLIENT_SECRET')] "secret": [current_app.config.get('ADMIN_CLIENT_SECRET')]
} }
elif client == current_app.config.get('DELIVERY_CLIENT_USER_NAME'):
return {
"client": client,
"secret": [current_app.config.get('DELIVERY_CLIENT_SECRET')]
}
else: else:
return { return {
"client": client, "client": client,

2
config.py
View File

@@ -9,8 +9,6 @@ class Config(object):
ADMIN_CLIENT_SECRET = os.environ['ADMIN_CLIENT_SECRET'] ADMIN_CLIENT_SECRET = os.environ['ADMIN_CLIENT_SECRET']
AWS_REGION = os.environ['AWS_REGION'] AWS_REGION = os.environ['AWS_REGION']
DANGEROUS_SALT = os.environ['DANGEROUS_SALT'] DANGEROUS_SALT = os.environ['DANGEROUS_SALT']
DELIVERY_CLIENT_USER_NAME = os.environ['DELIVERY_CLIENT_USER_NAME']
DELIVERY_CLIENT_SECRET = os.environ['DELIVERY_CLIENT_SECRET']
INVITATION_EXPIRATION_DAYS = int(os.environ['INVITATION_EXPIRATION_DAYS']) INVITATION_EXPIRATION_DAYS = int(os.environ['INVITATION_EXPIRATION_DAYS'])
INVITATION_EMAIL_FROM = os.environ['INVITATION_EMAIL_FROM'] INVITATION_EMAIL_FROM = os.environ['INVITATION_EMAIL_FROM']
NOTIFY_APP_NAME = 'api' NOTIFY_APP_NAME = 'api'

2
environment_test.sh
View File

@@ -5,8 +5,6 @@ export ADMIN_CLIENT_USER_NAME='dev-notify-admin'
export ADMIN_CLIENT_SECRET='dev-notify-secret-key' export ADMIN_CLIENT_SECRET='dev-notify-secret-key'
export AWS_REGION='eu-west-1' export AWS_REGION='eu-west-1'
export DANGEROUS_SALT='dangerous-salt' export DANGEROUS_SALT='dangerous-salt'
export DELIVERY_CLIENT_USER_NAME='dev-notify-delivery'
export DELIVERY_CLIENT_SECRET='dev-notify-secret-key'
export INVITATION_EMAIL_FROM='invites' export INVITATION_EMAIL_FROM='invites'
export INVITATION_EXPIRATION_DAYS=2 export INVITATION_EXPIRATION_DAYS=2
export NOTIFY_JOB_QUEUE='notify-jobs-queue-test' export NOTIFY_JOB_QUEUE='notify-jobs-queue-test'