Rename task from create_letters_pdf to get_pdf_for_templated_letter

In a separate PR we will have to delete vestigial create_letters_pdf
tasks that now only redirects to get_pdf_for_templated_letter.

app/celery/letters_pdf_tasks.py

@@ -49,6 +49,12 @@ from app.cronitor import cronitor
 @notify_celery.task(bind=True, name="create-letters-pdf", max_retries=15, default_retry_delay=300)
 @statsd(namespace="tasks")
 def create_letters_pdf(self, notification_id):
+    get_pdf_for_templated_letter(notification_id)
+
+
+@notify_celery.task(bind=True, name="get-pdf-for-templated-letter", max_retries=15, default_retry_delay=300)
+@statsd(namespace="tasks")
+def get_pdf_for_templated_letter(self, notification_id):
     try:
         notification = get_notification_by_id(notification_id, _raise=True)
 

app/celery/scheduled_tasks.py

@@ -14,7 +14,7 @@ from app.celery.tasks import (
     get_recipient_csv_and_template_and_sender_id,
     process_row
 )
-from app.celery.letters_pdf_tasks import create_letters_pdf
+from app.celery.letters_pdf_tasks import get_pdf_for_templated_letter
 from app.config import QueueNames, TaskNames
 from app.dao.invited_org_user_dao import delete_org_invitations_created_more_than_two_days_ago
 from app.dao.invited_user_dao import delete_invitations_created_more_than_two_days_ago
@@ -188,7 +188,7 @@ def replay_created_notifications():
 
         current_app.logger.info(msg)
         for letter in letters:
-            create_letters_pdf.apply_async([str(letter.id)], queue=QueueNames.CREATE_LETTERS_PDF)
+            get_pdf_for_templated_letter.apply_async([str(letter.id)], queue=QueueNames.CREATE_LETTERS_PDF)
 
 
 @notify_celery.task(name='check-precompiled-letter-state')

app/celery/tasks.py

@@ -371,7 +371,7 @@ def save_letter(
         )
 
         if not service.research_mode:
-            letters_pdf_tasks.create_letters_pdf.apply_async(
+            letters_pdf_tasks.get_pdf_for_templated_letter.apply_async(
                 [str(saved_notification.id)],
                 queue=QueueNames.CREATE_LETTERS_PDF
             )