darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 09:29:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

changed name of test fixture

Browse Source
This commit is contained in:
venusbb
2017-07-11 09:50:09 +01:00
parent 6b650c6d96
commit 5d57189187
3 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/authentication/auth.py
View File

@@ -53,7 +53,7 @@ def restrict_ip_sms():
ip = ip_list[len(ip_list) - 3] ip = ip_list[len(ip_list) - 3]
current_app.logger.info("Inbound sms ip route list {}".format(ip_route)) current_app.logger.info("Inbound sms ip route list {}".format(ip_route))
if ip in current_app.config.get('ALLOW_IP_INBOUND_SMS'): if ip in current_app.config.get('SMS_INBOUND_WHITELIST'):
current_app.logger.info("Inbound sms ip addresses {} passed ".format(ip)) current_app.logger.info("Inbound sms ip addresses {} passed ".format(ip))
return return
else: else:

2
app/config.py
View File

@@ -262,7 +262,7 @@ class Config(object):
FREE_SMS_TIER_FRAGMENT_COUNT = 250000 FREE_SMS_TIER_FRAGMENT_COUNT = 250000
ALLOW_IP_INBOUND_SMS = os.environ.get('SMS_INBOUND_WHITELIST', []) SMS_INBOUND_WHITELIST = os.environ.get('SMS_INBOUND_WHITELIST', [])
###################### ######################

16
tests/app/authentication/test_authentication.py
View File

@@ -313,8 +313,7 @@ def __create_token(service_id):
def restrict_ip_sms_app(): def restrict_ip_sms_app():
app = flask.Flask(__name__) app = flask.Flask(__name__)
app.config['TESTING'] = True app.config['TESTING'] = True
app.config['ALLOW_IP_INBOUND_SMS'] = ['111.111.111.111', '100.100.100.100'] app.config['SMS_INBOUND_WHITELIST'] = ['111.111.111.111', '100.100.100.100']
# app.config['ALLOW_IP_INBOUND_SMS'] = os.environ['SMS_INBOUND_WHITELIST']
blueprint = flask.Blueprint('restrict_ip_sms_app', __name__) blueprint = flask.Blueprint('restrict_ip_sms_app', __name__)
@blueprint.route('/') @blueprint.route('/')
@@ -350,3 +349,16 @@ def test_reject_invalid_ips(restrict_ip_sms_app):
) )
assert exc_info.value.short_message == 'Unknown source IP address from the SMS provider' assert exc_info.value.short_message == 'Unknown source IP address from the SMS provider'
@pytest.mark.xfail(reason='Currently not blocking invalid IPs', strict=True)
def test_illegitimate_ips(restrict_ip_sms_app):
with pytest.raises(AuthError) as exc_info:
restrict_ip_sms_app.get(
path='/',
headers=[
('X-Forwarded-For', '111.111.111.111, 999.999.999.999, 333.333.333.333, 127.0.0.1')
]
)
assert exc_info.value.short_message == 'Unknown source IP address from the SMS provider'