darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-26 17:23:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update ADR-0003 (Invite Expirations)

Browse Source 
This changest updates the Invite Expirations ADR (ADR-0003) to become accepted and ready for implementation. It also updates the index with recent ADR changes prior to the ADR process updates.

Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
This commit is contained in:
Carlo Costino
2023-09-15 17:29:44 -04:00
parent 37339b750b
commit 5bf716fe2d
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
docs/adrs/0003-implementing-invite-expirations.md
View File

@@ -3,7 +3,7 @@
| CREATED DATE | LAST UPDATED | STATUS | AUTHOR | STAKEHOLDERS | | CREATED DATE | LAST UPDATED | STATUS | AUTHOR | STAKEHOLDERS |
| :---: | :---: | :---: | :---: | :---: | | :---: | :---: | :---: | :---: | :---: |
| 06/06/2023 | 06/15/2023 | Proposed | @ccostino | @GSA/notify-contributors | | 06/06/2023 | 09/15/2023 | Accepted | @ccostino | @GSA/notify-contributors |
## CONTEXT AND PROBLEM STATEMENT ## CONTEXT AND PROBLEM STATEMENT
@@ -48,8 +48,7 @@ that are already in place, which prevent the following:
## CONSIDERED OPTIONS ## CONSIDERED OPTIONS
These are the different approaches we're considering for implementing this This is the approach we've considered for implementing this change:
change:
- **Adjust `InvitedUser` management in the API:** Instead of deleting - **Adjust `InvitedUser` management in the API:** Instead of deleting
`InvitedUser` objects, we manage them instead and track their `created_at` `InvitedUser` objects, we manage them instead and track their `created_at`
@@ -108,8 +107,6 @@ value for the effort.
## VALIDATION AND NEXT STEPS ## VALIDATION AND NEXT STEPS
TBD, pending additional ideas and discussion!
Once a decision is made though, a seperate issue should be written up for the Once a decision is made though, a seperate issue should be written up for the
API changes that need to take place, and then follow-on work will be needed on API changes that need to take place, and then follow-on work will be needed on
the admin side in https://github.com/GSA/notifications-admin/issues/96 to make the admin side in https://github.com/GSA/notifications-admin/issues/96 to make

3
docs/adrs/README.md
View File

@@ -180,8 +180,9 @@ top!).
| ADR | TITLE | CURRENT STATUS | IMPLEMENTED | LAST MODIFIED | | ADR | TITLE | CURRENT STATUS | IMPLEMENTED | LAST MODIFIED |
| :---: | :---: | :---: | :---: | :---: | | :---: | :---: | :---: | :---: | :---: |
| [ADR-0006](./0006-use-for-dependency-management.md) | [Use `poetry` for Dependency Management](./0006-use-for-dependency-management.md) | Accepted | Yes | 09/08/2023 |
| [ADR-0005](./0005-agreement-data-model.md) | [Agreement info in data model](./0005-agreement-data-model.md) | Accepted | No | 07/05/2023 | | [ADR-0005](./0005-agreement-data-model.md) | [Agreement info in data model](./0005-agreement-data-model.md) | Accepted | No | 07/05/2023 |
| [ADR-0004](./0004-designing-pilot-content-visibility.md) | [Designing Pilot Content Visibility](./0004-designing-pilot-content-visibility.md) | Proposed | No | 06/20/2023 | | [ADR-0004](./0004-designing-pilot-content-visibility.md) | [Designing Pilot Content Visibility](./0004-designing-pilot-content-visibility.md) | Proposed | No | 06/20/2023 |
| [ADR-0003](./0003-implementing-invite-expirations.md) | [Implementing User Invite Expirations](./0003-implementing-invite-expirations.md) | Proposed | No | 06/15/2023 | | [ADR-0003](./0003-implementing-invite-expirations.md) | [Implementing User Invite Expirations](./0003-implementing-invite-expirations.md) | Accepted | No | 09/15/2023 |
| [ADR-0002](./0002-how-to-handle-timezones.md) | [Determine How to Handle Timezones in US Notify](./0002-how-to-handle-timezones.md) | Accepted | Yes | 06/15/2023 | | [ADR-0002](./0002-how-to-handle-timezones.md) | [Determine How to Handle Timezones in US Notify](./0002-how-to-handle-timezones.md) | Accepted | Yes | 06/15/2023 |
| [ADR-0001](./0001-establishing-adrs-for-us-notify.md) | [Establishing ADRs for US Notify](./0001-establishing-adrs-for-us-notify.md) | Accepted | Yes | 06/15/2023 | | [ADR-0001](./0001-establishing-adrs-for-us-notify.md) | [Establishing ADRs for US Notify](./0001-establishing-adrs-for-us-notify.md) | Accepted | Yes | 06/15/2023 |