Refactor:

* Filter inbound by service_id
* Refactor to return 404 instead of 400 for consistency
This commit is contained in:
Imdad Ahad
2017-06-07 14:23:31 +01:00
parent ee488d416a
commit 5b4ceda1c6
4 changed files with 23 additions and 18 deletions

View File

@@ -49,5 +49,8 @@ def delete_inbound_sms_created_more_than_a_week_ago():
return deleted
def dao_get_inbound_sms_by_id(inbound_id):
return InboundSms.query.filter_by(id=inbound_id).one()
def dao_get_inbound_sms_by_id(service_id, inbound_id):
return InboundSms.query.filter_by(
id=inbound_id,
service_id=service_id
).one()