darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 18:01:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use new redis key for templates

Browse Source 
Equivalent of https://github.com/alphagov/notifications-admin/pull/3639
but for the API.

This is the only place in the API we appear to be getting setting
templates or broadcast messages.
This commit is contained in:
David McDonald
2020-09-21 17:16:33 +01:00
parent 120b760cae
commit 5b0cc8819a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/serialised_models.py
View File

@@ -55,7 +55,7 @@ class SerialisedTemplate(SerialisedModel):
return cls(cls.get_dict(template_id, service_id)['data']) return cls(cls.get_dict(template_id, service_id)['data'])
@staticmethod @staticmethod
@redis_cache.set('template-{template_id}-version-None') @redis_cache.set('service-{service_id}-template-{template_id}-version-None')
def get_dict(template_id, service_id): def get_dict(template_id, service_id):
from app.dao import templates_dao from app.dao import templates_dao
from app.schemas import template_schema from app.schemas import template_schema

2
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -264,7 +264,7 @@ def test_should_cache_template_and_service_in_redis(mocker, client, sample_templ
) )
expected_service_key = f'service-{sample_template.service_id}' expected_service_key = f'service-{sample_template.service_id}'
expected_templates_key = f'template-{sample_template.id}-version-None' expected_templates_key = f'service-{sample_template.service_id}-template-{sample_template.id}-version-None'
assert mock_redis_get.call_args_list == [ assert mock_redis_get.call_args_list == [
call(expected_service_key), call(expected_service_key),