Removed the _delivery_status endpoint.

The test this status check was doing does not reflect real traffic of Notify. It is typical for messages to be in 'sending' for a while (people turn off their phone for example).
This commit is contained in:
Rebecca Law
2017-10-17 15:51:42 +01:00
parent bfb54a3b98
commit 5aa37f09b6
2 changed files with 4 additions and 79 deletions

View File

@@ -1,17 +1,10 @@
from datetime import (
datetime,
timedelta
)
from flask import (
jsonify,
Blueprint,
request,
current_app
request
)
from app import db, version
from app.models import Notification
status = Blueprint('status', __name__)
@@ -29,38 +22,7 @@ def show_status():
db_version=get_db_version()), 200
@status.route('/_delivery_status')
def show_delivery_status():
if request.args.get('elb', None):
return jsonify(status="ok"), 200
else:
notifications_alert = current_app.config['NOTIFICATIONS_ALERT']
some_number_of_minutes_ago = datetime.utcnow() - timedelta(minutes=notifications_alert)
notifications = Notification.query.filter(Notification.status == 'sending',
Notification.created_at < some_number_of_minutes_ago).all()
message = "{} notifications in sending state over {} minutes".format(len(notifications), notifications_alert)
if notifications:
return jsonify(
status="error",
message=message,
travis_commit=version.__travis_commit__,
travis_build_number=version.__travis_job_number__,
build_time=version.__time__,
db_version=get_db_version()), 500
return jsonify(
status="ok",
message=message,
travis_commit=version.__travis_commit__,
travis_build_number=version.__travis_job_number__,
build_time=version.__time__,
db_version=get_db_version()), 200
def get_db_version():
try:
query = 'SELECT version_num FROM alembic_version'
full_name = db.session.execute(query).fetchone()[0]
return full_name
except:
return 'n/a'
query = 'SELECT version_num FROM alembic_version'
full_name = db.session.execute(query).fetchone()[0]
return full_name