darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-14 23:07:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Rename JSONModel to SerialisedModel 2/2

Browse Source 
This class doesn’t actually wrap JSON, it wraps serialised data.

So this name feels better.
This commit is contained in:
Chris Hill-Scott
2020-06-22 10:20:53 +01:00
parent e6b7e0e16c
commit 5a2f2a9ec2
5 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/app/notifications/test_process_notification.py
View File

@@ -20,14 +20,14 @@ from app.notifications.process_notifications import (
send_notification_to_queue,
simulated_recipient
)
from app.serialised_models import TemplateJSONModel
from app.serialised_models import SerialisedTemplate
from notifications_utils.recipients import validate_and_format_phone_number, validate_and_format_email_address
from app.v2.errors import BadRequestError
from tests.app.db import create_service, create_template, create_api_key
def test_create_content_for_notification_passes(sample_email_template):
template = TemplateJSONModel.from_id_and_service_id(
template = SerialisedTemplate.from_id_and_service_id(
sample_email_template.id, sample_email_template.service_id
)
content = create_content_for_notification(template, None)
@@ -35,7 +35,7 @@ def test_create_content_for_notification_passes(sample_email_template):
def test_create_content_for_notification_with_placeholders_passes(sample_template_with_placeholders):
template = TemplateJSONModel.from_id_and_service_id(
template = SerialisedTemplate.from_id_and_service_id(
sample_template_with_placeholders.id, sample_template_with_placeholders.service_id
)
content = create_content_for_notification(template, {'name': 'Bobby'})
@@ -44,7 +44,7 @@ def test_create_content_for_notification_with_placeholders_passes(sample_templat
def test_create_content_for_notification_fails_with_missing_personalisation(sample_template_with_placeholders):
template = TemplateJSONModel.from_id_and_service_id(
template = SerialisedTemplate.from_id_and_service_id(
sample_template_with_placeholders.id, sample_template_with_placeholders.service_id
)
with pytest.raises(BadRequestError):
@@ -52,7 +52,7 @@ def test_create_content_for_notification_fails_with_missing_personalisation(samp
def test_create_content_for_notification_allows_additional_personalisation(sample_template_with_placeholders):
template = TemplateJSONModel.from_id_and_service_id(
template = SerialisedTemplate.from_id_and_service_id(
sample_template_with_placeholders.id, sample_template_with_placeholders.service_id
)
create_content_for_notification(template, {'name': 'Bobby', 'Additional placeholder': 'Data'})