diff --git a/tests/app/dao/test_service_sms_sender_dao.py b/tests/app/dao/test_service_sms_sender_dao.py index 50b2a71ff..9ca05e711 100644 --- a/tests/app/dao/test_service_sms_sender_dao.py +++ b/tests/app/dao/test_service_sms_sender_dao.py @@ -159,16 +159,11 @@ def test_dao_update_service_sms_sender_switches_default(notify_db_session): is_default=True, sms_sender="updated", ) - sms_senders = ( - ServiceSmsSender.query.filter_by(service_id=service.id) - .order_by(ServiceSmsSender.created_at) - .all() - ) - assert len(sms_senders) == 2 - assert sms_senders[0].sms_sender == "testing" - assert not sms_senders[0].is_default - assert sms_senders[1].sms_sender == "updated" - assert sms_senders[1].is_default + sms_senders = ServiceSmsSender.query.filter_by(service_id=service.id).all() + + expected = {("testing", False), ("updated", True)} + results = {(sender.sms_sender, sender.is_default) for sender in sms_senders} + assert expected == results def test_dao_update_service_sms_sender_raises_exception_when_no_default_after_update(