darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update logging for provider tasks.

Browse Source 
Move the info message before the fetch.
Include the exception in the log message.
This commit is contained in:
Rebecca Law
2018-03-26 15:24:21 +01:00
parent bdae669b05
commit 598539dcb3
2 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/celery/provider_tasks.py
View File

@@ -22,15 +22,15 @@ def worker_process_shutdown(sender, signal, pid, exitcode):
@statsd(namespace="tasks")
def deliver_sms(self, notification_id):
try:
current_app.logger.info("Start sending SMS for notification id: {}".format(notification_id))
notification = notifications_dao.get_notification_by_id(notification_id)
if not notification:
raise NoResultFound()
current_app.logger.info("Start sending SMS for notification id: {}".format(notification_id))
send_to_providers.send_sms_to_provider(notification)
except Exception as e:
try:
current_app.logger.exception(
"SMS notification delivery for id: {} failed".format(notification_id)
"SMS notification delivery for id: {} failed".format(notification_id), e
)
self.retry(queue=QueueNames.RETRY)
except self.MaxRetriesExceededError:
@@ -44,10 +44,10 @@ def deliver_sms(self, notification_id):
@statsd(namespace="tasks")
def deliver_email(self, notification_id):
try:
current_app.logger.info("Start sending email for notification id: {}".format(notification_id))
notification = notifications_dao.get_notification_by_id(notification_id)
if not notification:
raise NoResultFound()
current_app.logger.info("Start sending email for notification id: {}".format(notification_id))
send_to_providers.send_email_to_provider(notification)
except InvalidEmailError as e:
current_app.logger.exception(e)
@@ -55,7 +55,7 @@ def deliver_email(self, notification_id):
except Exception as e:
try:
current_app.logger.exception(
"RETRY: Email notification {} failed".format(notification_id)
"RETRY: Email notification {} failed".format(notification_id), e
)
self.retry(queue=QueueNames.RETRY)
except self.MaxRetriesExceededError: