From 5975ae23839d7f4c66eb7578de5bfb13d11e6795 Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Fri, 30 Aug 2019 16:49:58 +0100 Subject: [PATCH] remove unneccessary duped lines as per pr comments --- app/commands.py | 2 -- app/dao/fact_billing_dao.py | 1 - 2 files changed, 3 deletions(-) diff --git a/app/commands.py b/app/commands.py index 58698ac4e..8f83767b3 100644 --- a/app/commands.py +++ b/app/commands.py @@ -278,8 +278,6 @@ def populate_annual_billing(year): free_sms_fragment_limit=free_allowance[0], financial_year_start=int(year)) - db.session.commit() - @notify_command(name='list-routes') def list_routes(): diff --git a/app/dao/fact_billing_dao.py b/app/dao/fact_billing_dao.py index 90fafc5c2..19f5e231c 100644 --- a/app/dao/fact_billing_dao.py +++ b/app/dao/fact_billing_dao.py @@ -161,7 +161,6 @@ def fetch_letter_line_items_for_all_services(start_date, end_date): ).join( FactBilling, FactBilling.service_id == Service.id, ).filter( - FactBilling.service_id == Service.id, FactBilling.bst_date >= start_date, FactBilling.bst_date <= end_date, FactBilling.notification_type == LETTER_TYPE,