darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-14 17:22:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #183 from GSA/brokerpak-setup-updates

Browse Source 
Brokerpak setup updates
This commit is contained in:
Ryan Ahearn
2023-02-24 15:29:56 -05:00
committed by GitHub
parent 8d595dd730 71010e78d8
commit 58f8ca47bf
4 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/users_dao.py
View File

@@ -21,7 +21,7 @@ def _remove_values_for_keys_if_present(dict, keys):
def create_secret_code(length=6): def create_secret_code(length=6):
random_number = randbelow(10 ** length) random_number = randbelow(10 ** length)
return f"{random_number:06d}" return "{:0{length}d}".format(random_number, length=length)
def save_user_attribute(usr, update_dict=None): def save_user_attribute(usr, update_dict=None):

24
terraform/demo/main.tf
View File

@@ -63,22 +63,18 @@ module "ses_email" {
cf_space_name = local.cf_space_name cf_space_name = local.cf_space_name
name = "${local.app_name}-ses-${local.env}" name = "${local.app_name}-ses-${local.env}"
recursive_delete = local.recursive_delete recursive_delete = local.recursive_delete
aws_region = "us-gov-west-1" aws_region = "us-west-2"
email_domain = "notify.sandbox.10x.gsa.gov" email_domain = "notify.sandbox.10x.gsa.gov"
email_receipt_error = "notify-support@gsa.gov" email_receipt_error = "notify-support@gsa.gov"
} }
######################################################################### module "sns_sms" {
# Wait for SNS is out of sandbox and spending limit is increased source = "../shared/sns"
# before activating this module
#########################################################################
# module "sns_sms" {
# source = "../shared/sns"
# cf_org_name = local.cf_org_name cf_org_name = local.cf_org_name
# cf_space_name = local.cf_space_name cf_space_name = local.cf_space_name
# name = "${local.app_name}-sns-${local.env}" name = "${local.app_name}-sns-${local.env}"
# recursive_delete = local.recursive_delete recursive_delete = local.recursive_delete
# aws_region = "us-gov-east-1" aws_region = "us-east-1"
# monthly_spend_limit = 25 monthly_spend_limit = 25
# } }

24
terraform/sandbox/main.tf
View File

@@ -67,17 +67,13 @@ module "ses_email" {
email_receipt_error = "notify-support@gsa.gov" email_receipt_error = "notify-support@gsa.gov"
} }
############################################################### module "sns_sms" {
# By default, sandbox uses the shared service instance from the source = "../shared/sns"
# staging space
############################################################### cf_org_name = local.cf_org_name
# module "sns_sms" { cf_space_name = local.cf_space_name
# source = "../shared/sns" name = "${local.app_name}-sns-${local.env}"
# recursive_delete = local.recursive_delete
# cf_org_name = local.cf_org_name aws_region = "us-east-2"
# cf_space_name = local.cf_space_name monthly_spend_limit = 1
# name = "${local.app_name}-sns-${local.env}" }
# recursive_delete = local.recursive_delete
# aws_region = "us-west-2"
# monthly_spend_limit = 1
# }

8
tests/app/dao/test_users_dao.py
View File

@@ -185,7 +185,13 @@ def test_create_secret_code_different_subsequent_codes():
def test_create_secret_code_returns_6_digits(): def test_create_secret_code_returns_6_digits():
code = create_secret_code() code = create_secret_code()
assert len(str(code)) == 6 assert len(code) == 6
def test_create_secret_code_can_customize_digits():
code_length = 10
code = create_secret_code(code_length)
assert len(code) == code_length
@freeze_time('2018-07-07 12:00:00') @freeze_time('2018-07-07 12:00:00')