mirror of
https://github.com/GSA/notifications-api.git
synced 2025-12-23 00:41:35 -05:00
Bump utils to allow lists as placeholder values
Brings in: - [ ] https://github.com/alphagov/notifications-utils/pull/128 Also adds a test to make sure that passing a dictionary as a value in the `personalisation` argument works.
This commit is contained in:
committed by
Leo Hemsted
parent
27e4007fb5
commit
585ef8e66a
@@ -29,6 +29,6 @@ notifications-python-client>=3.1,<3.2
|
|||||||
awscli>=1.11,<1.12
|
awscli>=1.11,<1.12
|
||||||
awscli-cwlogs>=1.4,<1.5
|
awscli-cwlogs>=1.4,<1.5
|
||||||
|
|
||||||
git+https://github.com/alphagov/notifications-utils.git@13.9.6#egg=notifications-utils==13.9.6
|
git+https://github.com/alphagov/notifications-utils.git@14.0.0#egg=notifications-utils==14.0.0
|
||||||
|
|
||||||
git+https://github.com/alphagov/boto.git@2.43.0-patch3#egg=boto==2.43.0-patch3
|
git+https://github.com/alphagov/boto.git@2.43.0-patch3#egg=boto==2.43.0-patch3
|
||||||
|
|||||||
@@ -133,6 +133,42 @@ def test_send_notification_with_placeholders_replaced(notify_api, sample_email_t
|
|||||||
assert response_data['subject'] == 'Jo'
|
assert response_data['subject'] == 'Jo'
|
||||||
|
|
||||||
|
|
||||||
|
def test_send_notification_with_placeholders_replaced_with_list(
|
||||||
|
client,
|
||||||
|
sample_email_template_with_placeholders,
|
||||||
|
mocker
|
||||||
|
):
|
||||||
|
mocked = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
|
||||||
|
|
||||||
|
response = client.post(
|
||||||
|
path='/notifications/email',
|
||||||
|
data=json.dumps(
|
||||||
|
{
|
||||||
|
'to': 'ok@ok.com',
|
||||||
|
'template': str(sample_email_template_with_placeholders.id),
|
||||||
|
'personalisation': {
|
||||||
|
'name': ['Jo', 'John', 'Josephine']
|
||||||
|
}
|
||||||
|
}
|
||||||
|
),
|
||||||
|
headers=[
|
||||||
|
('Content-Type', 'application/json'),
|
||||||
|
create_authorization_header(service_id=sample_email_template_with_placeholders.service.id)
|
||||||
|
]
|
||||||
|
)
|
||||||
|
|
||||||
|
response_data = json.loads(response.data)['data']
|
||||||
|
assert response.status_code == 201
|
||||||
|
assert response_data['body'] == (
|
||||||
|
'Hello \n\n'
|
||||||
|
'* Jo\n'
|
||||||
|
'* John\n'
|
||||||
|
'* Josephine\n'
|
||||||
|
'This is an email from GOV.\u200BUK'
|
||||||
|
)
|
||||||
|
assert response_data['subject'] == 'Jo, John and Josephine'
|
||||||
|
|
||||||
|
|
||||||
def test_should_not_send_notification_for_archived_template(notify_api, sample_template):
|
def test_should_not_send_notification_for_archived_template(notify_api, sample_template):
|
||||||
with notify_api.test_request_context():
|
with notify_api.test_request_context():
|
||||||
with notify_api.test_client() as client:
|
with notify_api.test_client() as client:
|
||||||
|
|||||||
Reference in New Issue
Block a user