darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-09 15:29:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

cleanup

Browse Source
This commit is contained in:
Kenneth Kehl
2025-06-04 08:03:01 -07:00
parent 5eade384c5
commit 57f98b1507
4 changed files with 5 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.ds.baseline
View File

@@ -161,7 +161,7 @@
"filename": ".github/workflows/daily_checks.yml", "filename": ".github/workflows/daily_checks.yml",
"hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8", "hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
"is_verified": false, "is_verified": false,
"line_number": 71, "line_number": 63,
"is_secret": false "is_secret": false
}, },
{ {
@@ -169,7 +169,7 @@
"filename": ".github/workflows/daily_checks.yml", "filename": ".github/workflows/daily_checks.yml",
"hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8", "hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
"is_verified": false, "is_verified": false,
"line_number": 87, "line_number": 79,
"is_secret": false "is_secret": false
} }
], ],
@@ -384,5 +384,5 @@
} }
] ]
}, },
"generated_at": "2025-06-02T13:22:36Z" "generated_at": "2025-06-04T15:02:41Z"
} }

10
.github/workflows/checks.yml vendored
View File

@@ -87,15 +87,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: ./.github/actions/setup-project - uses: ./.github/actions/setup-project
- name: Create requirements.txt - name: Create requirements.txt
run: poetry export --output requirements_tmp.txt --without-hashes run: poetry export --output requirements.txt
- name: Filter requirements.txt
run: grep -v "oscrypto@ git" requirements_tmp.txt > requirements.txt
- name: Verify requirements.txt
run: ls -l requirements.txt
- name: Print requirements.txt
run: |
echo "Contents of requirements.txt:"
cat requirements.txt
- uses: pypa/gh-action-pip-audit@v1.1.0 - uses: pypa/gh-action-pip-audit@v1.1.0
with: with:
inputs: requirements.txt inputs: requirements.txt

10
.github/workflows/daily_checks.yml vendored
View File

@@ -26,15 +26,7 @@ jobs:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
- uses: ./.github/actions/setup-project - uses: ./.github/actions/setup-project
- name: Create requirements.txt - name: Create requirements.txt
run: poetry export --output requirements_tmp.txt --without-hashes run: poetry export --output requirements.txt
- name: Filter requirements.txt
run: grep -v "oscrypto@ git" requirements_tmp.txt > requirements.txt
- name: Verify requirements.txt
run: ls -l requirements.txt
- name: Print requirements.txt
run: |
echo "Contents of requirements.txt:"
cat requirements.txt
- uses: pypa/gh-action-pip-audit@v1.1.0 - uses: pypa/gh-action-pip-audit@v1.1.0
with: with:
inputs: requirements.txt inputs: requirements.txt

10
app/notifications/sns_cert_validator.py
View File

@@ -4,9 +4,6 @@ from urllib.parse import urlparse
import requests import requests
import six import six
# import oscrypto.asymmetric
# import oscrypto.errors
from cryptography import x509 from cryptography import x509
from cryptography.exceptions import InvalidSignature from cryptography.exceptions import InvalidSignature
from cryptography.hazmat.primitives import hashes from cryptography.hazmat.primitives import hashes
@@ -125,13 +122,6 @@ def validate_sns_cert(sns_payload):
public_key.verify( public_key.verify(
signature, string_to_sign, padding.PKCS1v15(), hashes.SHA256() # or SHA1? signature, string_to_sign, padding.PKCS1v15(), hashes.SHA256() # or SHA1?
) )
# oscrypto.asymmetric.rsa_pkcs1v15_verify(
# oscrypto.asymmetric.load_certificate(certificate),
# signature,
# string_to_sign,
# "sha1",
# )
return True return True
# except oscrypto.errors.SignatureError:
except InvalidSignature: except InvalidSignature:
raise ValidationError("Invalid signature") raise ValidationError("Invalid signature")