darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 05:58:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix personalisation

Browse Source
This commit is contained in:
Kenneth Kehl
2024-01-18 10:03:35 -08:00
parent 40f8718a61
commit 567dd390b4
9 changed files with 87 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/app/aws/test_s3.py
View File

@@ -7,6 +7,7 @@ from botocore.exceptions import ClientError
from app.aws.s3 import (
file_exists,
get_personalisation_from_s3,
get_phone_number_from_s3,
get_s3_file,
remove_csv_object,
@@ -73,6 +74,35 @@ def test_get_phone_number_from_s3(
assert phone_number == expected_phone_number
@pytest.mark.parametrize(
"job, job_id, job_row_number, expected_personalisation",
[
("phone number\r\n+15555555555", "aaa", 0, {"phone number": "+15555555555"}),
(
"day of week,favorite color,phone number\r\nmonday,green,1.555.111.1111\r\ntuesday,red,+1 (555) 222-2222",
"bbb",
1,
{"day of week": "tuesday", "favorite color": "red", "phone number": "+1 (555) 222-2222"},
),
(
"day of week,favorite color,phone number\r\nmonday,green,1.555.111.1111\r\ntuesday,red,+1 (555) 222-2222",
"ccc",
0,
{"day of week": "monday", "favorite color": "green", "phone number": "1.555.111.1111"},
),
],
)
def test_get_personalisation_from_s3(
mocker, job, job_id, job_row_number, expected_personalisation
):
mocker.patch("app.aws.s3.redis_store")
get_job_mock = mocker.patch("app.aws.s3.get_job_from_s3")
get_job_mock.return_value = job
personalisation = get_personalisation_from_s3("service_id", job_id, job_row_number)
assert personalisation == expected_personalisation
def test_remove_csv_object(notify_api, mocker):
get_s3_mock = mocker.patch("app.aws.s3.get_s3_object")
remove_csv_object("mykey")