darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #814 from GSA/notify-api-809

Browse Source 
If phone number is unavailable, change text to 'Unavailable'
This commit is contained in:
Carlo Costino
2024-02-27 10:47:49 -05:00
committed by GitHub
parent 24e379cfa8 f508ff2c76
commit 55dc017205
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/aws/s3.py
View File

@@ -117,7 +117,7 @@ def extract_phones(job):
current_app.logger.info(f"PHONE INDEX IS NOW {phone_index}") current_app.logger.info(f"PHONE INDEX IS NOW {phone_index}")
current_app.logger.info(f"LENGTH OF ROW IS {len(row)}") current_app.logger.info(f"LENGTH OF ROW IS {len(row)}")
if phone_index >= len(row): if phone_index >= len(row):
phones[job_row] = "Error: can't retrieve phone number" phones[job_row] = "Unavailable"
current_app.logger.error( current_app.logger.error(
"Corrupt csv file, missing columns or possibly a byte order mark in the file" "Corrupt csv file, missing columns or possibly a byte order mark in the file"
) )
@@ -151,7 +151,7 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
current_app.logger.warning( current_app.logger.warning(
f"Couldnt find phone for job_id {job_id} row number {job_row_number} because job is missing" f"Couldnt find phone for job_id {job_id} row number {job_row_number} because job is missing"
) )
return "Unknown Phone" return "Unavailable"
# If we look in the JOBS cache for the quick lookup dictionary of phones for a given job # If we look in the JOBS cache for the quick lookup dictionary of phones for a given job
# and that dictionary is not there, create it # and that dictionary is not there, create it
@@ -167,12 +167,12 @@ def get_phone_number_from_s3(service_id, job_id, job_row_number):
current_app.logger.warning( current_app.logger.warning(
f"Was unable to retrieve phone number from lookup dictionary for job {job_id}" f"Was unable to retrieve phone number from lookup dictionary for job {job_id}"
) )
return "Unknown Phone" return "Unavailable"
else: else:
current_app.logger.error( current_app.logger.error(
f"Was unable to construct lookup dictionary for job {job_id}" f"Was unable to construct lookup dictionary for job {job_id}"
) )
return "Unknown Phone" return "Unavailable"
def get_job_metadata_from_s3(service_id, job_id): def get_job_metadata_from_s3(service_id, job_id):