From 8aacfb289d5c5b18d21de9fa5e493654cc8fb163 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Fri, 7 Sep 2018 10:22:45 +0100 Subject: [PATCH] Add created_by_name to the Notification.serialize_for_csv. The concern about performnace degrading has been thought through. We do not believe there will be an adverse effect since the high volume users do not send off messages. --- app/models.py | 3 ++- tests/app/job/test_rest.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/models.py b/app/models.py index 353b6e56c..87761b147 100644 --- a/app/models.py +++ b/app/models.py @@ -1324,7 +1324,8 @@ class Notification(db.Model): "template_type": self.template.template_type, "job_name": self.job.original_file_name if self.job else '', "status": self.formatted_status, - "created_at": time.strftime('%A %d %B %Y at %H:%M', created_at_in_bst.timetuple()) + "created_at": time.strftime('%A %d %B %Y at %H:%M', created_at_in_bst.timetuple()), + "created_by_name": self.get_created_by_name(), } return serialized diff --git a/tests/app/job/test_rest.py b/tests/app/job/test_rest.py index a147267f4..6bcdaa684 100644 --- a/tests/app/job/test_rest.py +++ b/tests/app/job/test_rest.py @@ -815,4 +815,5 @@ def test_get_all_notifications_for_job_returns_csv_format( assert len(resp['notifications']) == 1 notification = resp['notifications'][0] assert set(notification.keys()) == \ - set(['created_at', 'template_type', 'template_name', 'job_name', 'status', 'row_number', 'recipient']) + set(['created_at', 'created_by_name', 'template_type', + 'template_name', 'job_name', 'status', 'row_number', 'recipient'])