From 5790f52388f8893691c9046a59c38d40e48250dd Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Mon, 18 Sep 2023 13:09:46 -0400 Subject: [PATCH 1/2] Add missing environment variables from cf push This changeset actually adds the missing E2E test environment variables to the cf push command. Signed-off-by: Carlo Costino --- .github/workflows/deploy-demo.yml | 2 ++ .github/workflows/deploy-prod.yml | 2 ++ .github/workflows/deploy.yml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/deploy-demo.yml b/.github/workflows/deploy-demo.yml index 5543c0895..078f66ed7 100644 --- a/.github/workflows/deploy-demo.yml +++ b/.github/workflows/deploy-demo.yml @@ -68,6 +68,8 @@ jobs: --var SECRET_KEY="$SECRET_KEY" --var ADMIN_CLIENT_SECRET="$ADMIN_CLIENT_SECRET" --var NEW_RELIC_LICENSE_KEY="$NEW_RELIC_LICENSE_KEY" + --var NOTIFY_E2E_TEST_EMAIL="$NOTIFY_E2E_TEST_EMAIL" + --var NOTIFY_E2E_TEST_PASSWORD="$NOTIFY_E2E_TEST_PASSWORD" - name: Check for changes to egress config id: changed-egress-config diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml index ab1e89d7c..4ef3ffcba 100644 --- a/.github/workflows/deploy-prod.yml +++ b/.github/workflows/deploy-prod.yml @@ -72,6 +72,8 @@ jobs: --var SECRET_KEY="$SECRET_KEY" --var ADMIN_CLIENT_SECRET="$ADMIN_CLIENT_SECRET" --var NEW_RELIC_LICENSE_KEY="$NEW_RELIC_LICENSE_KEY" + --var NOTIFY_E2E_TEST_EMAIL="$NOTIFY_E2E_TEST_EMAIL" + --var NOTIFY_E2E_TEST_PASSWORD="$NOTIFY_E2E_TEST_PASSWORD" - name: Check for changes to egress config id: changed-egress-config diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0f2faf051..e0df02a6b 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -73,6 +73,8 @@ jobs: --var SECRET_KEY="$SECRET_KEY" --var ADMIN_CLIENT_SECRET="$ADMIN_CLIENT_SECRET" --var NEW_RELIC_LICENSE_KEY="$NEW_RELIC_LICENSE_KEY" + --var NOTIFY_E2E_TEST_EMAIL="$NOTIFY_E2E_TEST_EMAIL" + --var NOTIFY_E2E_TEST_PASSWORD="$NOTIFY_E2E_TEST_PASSWORD" - name: Check for changes to egress config id: changed-egress-config From 53ec9e504172d62840f47ef661c847369ab9f935 Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Mon, 18 Sep 2023 13:24:15 -0400 Subject: [PATCH 2/2] Update the manifest.yml file too Signed-off-by: Carlo Costino --- manifest.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/manifest.yml b/manifest.yml index 44dd270c4..eb78a7dc1 100644 --- a/manifest.yml +++ b/manifest.yml @@ -43,6 +43,8 @@ applications: NOTIFY_ENVIRONMENT: ((env)) API_HOST_NAME: https://((public_api_route)) ADMIN_BASE_URL: ((admin_base_url)) + NOTIFY_E2E_TEST_EMAIL: ((NOTIFY_E2E_TEST_EMAIL)) + NOTIFY_E2E_TEST_PASSWORD: ((NOTIFY_E2E_TEST_PASSWORD)) # Credentials variables INTERNAL_CLIENT_API_KEYS: '{"notify-admin":["((ADMIN_CLIENT_SECRET))"]}'