From 29b64cae5d8642aadb2880ba5f2169a9cdea8a0a Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Mon, 18 Sep 2023 10:46:34 -0400 Subject: [PATCH 1/2] Add total message limit default to existing services This changeset adds a migration to add a default total message limit to any pre-existing service that does not already have one set. It bases this value on the default set in the Flask app config. Signed-off-by: Carlo Costino --- .../0402_total_message_limit_default.py | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 migrations/versions/0402_total_message_limit_default.py diff --git a/migrations/versions/0402_total_message_limit_default.py b/migrations/versions/0402_total_message_limit_default.py new file mode 100644 index 000000000..b1e1c7c04 --- /dev/null +++ b/migrations/versions/0402_total_message_limit_default.py @@ -0,0 +1,32 @@ +""" + +Revision ID: e1ca86e9c5d4 +Revises: 0401_add_e2e_test_user +Create Date: 2023-09-18 10:04:58.957374 + +""" +from alembic import op +from flask import current_app +import sqlalchemy as sa + + +revision = '0402_total_message_limit_default' +down_revision = '0401_add_e2e_test_user' + + +def upgrade(): + # Set a default value for the total_message_limit column in the + # services table to match the current TOTAL_MESSAGE_LIMIT app + # config. + op.execute( + "UPDATE services SET total_message_limit = {total_message_limit} WHERE total_message_limit IS NULL".format( + total_message_limit=current_app.config["TOTAL_MESSAGE_LIMIT"] + ) + ) + + +def downgrade(): + # There is no downgrade from this migration as it would cause a bug + # in the app; if it needs to be removed, then you have to remove the + # column added in migration 0400. + pass From 0fa53d943abd75756d9f380ec71ebe5f8e857700 Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Mon, 18 Sep 2023 10:54:41 -0400 Subject: [PATCH 2/2] Fixed ID reference in Alembic comment h/t to @stvnrlly for the catch! Signed-off-by: Carlo Costino --- migrations/versions/0402_total_message_limit_default.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migrations/versions/0402_total_message_limit_default.py b/migrations/versions/0402_total_message_limit_default.py index b1e1c7c04..786e60362 100644 --- a/migrations/versions/0402_total_message_limit_default.py +++ b/migrations/versions/0402_total_message_limit_default.py @@ -1,6 +1,6 @@ """ -Revision ID: e1ca86e9c5d4 +Revision ID: 0402_total_message_limit_default Revises: 0401_add_e2e_test_user Create Date: 2023-09-18 10:04:58.957374