diff --git a/app/celery/tasks.py b/app/celery/tasks.py index f11a13e54..4cc5fd923 100644 --- a/app/celery/tasks.py +++ b/app/celery/tasks.py @@ -645,8 +645,6 @@ def _generate_notifications_report(service_id, report_id, limit_days): region=region, bucket_name=bucket_name, file_location=file_location, - access_key=access_key, - secret_key=secret_key, ) current_app.logger.info(f"generate-notifications-report uploaded {file_location}") diff --git a/notifications_utils/s3.py b/notifications_utils/s3.py index 0cf7c4da7..88c25548b 100644 --- a/notifications_utils/s3.py +++ b/notifications_utils/s3.py @@ -66,9 +66,16 @@ def s3upload( metadata = put_args["Metadata"] = metadata try: + current_app.logger.info(f"Going to try to upload this {key}") key.put(**put_args) + except botocore.exceptions.NoCredentialsError as e: + current_app.logger.exception( + f"Unable to upload {key} to S3 bucket because of {e}" + ) except botocore.exceptions.ClientError as e: - current_app.logger.exception("Unable to upload file to S3 bucket") + current_app.logger.exception( + f"Unable to upload {key}to S3 bucket because of {e}" + ) raise e