diff --git a/app/celery/tasks.py b/app/celery/tasks.py index 28eae3556..d3ccbdfc4 100644 --- a/app/celery/tasks.py +++ b/app/celery/tasks.py @@ -375,20 +375,6 @@ def send_email(service_id, notification_id, from_address, encrypted_notification current_app.logger.exception(e) -@notify_celery.task(name='send-sms-code') -def send_sms_code(encrypted_verification): - provider = provider_to_use('sms', 'send-sms-code') - - verification_message = encryption.decrypt(encrypted_verification) - try: - provider.send_sms(validate_and_format_phone_number(verification_message['to']), - "{} is your Notify authentication code".format( - verification_message['secret_code']), - 'send-sms-code') - except SmsClientException as e: - current_app.logger.exception(e) - - # TODO: when placeholders in templates work, this will be a real template def invitation_template(user_name, service_name, url, expiry_date): from string import Template diff --git a/tests/app/celery/test_tasks.py b/tests/app/celery/test_tasks.py index c2077d97e..7034368d8 100644 --- a/tests/app/celery/test_tasks.py +++ b/tests/app/celery/test_tasks.py @@ -6,7 +6,6 @@ from notifications_utils.recipients import validate_phone_number, format_phone_n from app.celery.tasks import ( send_sms, - send_sms_code, send_email, process_job, email_invited_user, @@ -898,33 +897,6 @@ def test_should_not_send_email_if_db_peristance_failed(sample_email_template, mo assert 'No row was found for one' in str(e.value) -def test_should_send_sms_code(mocker): - notification = {'to': '+447234123123', - 'secret_code': '12345'} - - encrypted_notification = encryption.encrypt(notification) - - mocker.patch('app.mmg_client.send_sms') - send_sms_code(encrypted_notification) - mmg_client.send_sms.assert_called_once_with( - format_phone_number(validate_phone_number(notification['to'])), - "{} is your Notify authentication code".format(notification['secret_code']), - 'send-sms-code') - - -def test_should_throw_mmg_client_exception(mocker): - notification = {'to': '+447234123123', - 'secret_code': '12345'} - - encrypted_notification = encryption.encrypt(notification) - mocker.patch('app.mmg_client.send_sms', side_effect=MMGClientException(mmg_error)) - send_sms_code(encrypted_notification) - mmg_client.send_sms.assert_called_once_with( - format_phone_number(validate_phone_number(notification['to'])), - "{} is your Notify authentication code".format(notification['secret_code']), - 'send-sms-code') - - def test_email_invited_user_should_send_email(notify_api, mocker): with notify_api.test_request_context(): invitation = {'to': 'new_person@it.gov.uk',