darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 14:31:57 -05:00
Code Issues Packages Projects Releases Wiki Activity

Increase the number of days we calculate billing from 3 to 10 days.

Browse Source 
Log exception if the billing counts for letters are different in the dvla response file than what we collected.
This commit is contained in:
Rebecca Law
2018-07-24 16:28:30 +01:00
parent 1b21a12b83
commit 4fc004b00a
4 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/celery/test_ftp_update_tasks.py
View File

@@ -308,7 +308,7 @@ def test_check_billable_units_when_billable_units_does_not_match_page_count(
mocker,
notification_update
):
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.error')
mock_logger = mocker.patch('app.celery.tasks.current_app.logger.exception')
notification = create_notification(sample_letter_template, reference='REFERENCE_ABC', billable_units=3)

8
tests/app/celery/test_reporting_tasks.py
View File

@@ -287,7 +287,7 @@ def test_create_nightly_billing_consolidate_from_3_days_delta(
mocker.patch('app.dao.fact_billing_dao.get_rate', side_effect=mocker_get_rate)
# create records from 11th to 15th
for i in range(0, 5):
for i in range(0, 11):
sample_notification(
notify_db,
notify_db_session,
@@ -302,7 +302,7 @@ def test_create_nightly_billing_consolidate_from_3_days_delta(
)
notification = Notification.query.order_by(Notification.created_at).all()
assert datetime.date(notification[0].created_at) == date(2018, 1, 11)
assert datetime.date(notification[0].created_at) == date(2018, 1, 5)
records = FactBilling.query.all()
assert len(records) == 0
@@ -310,8 +310,8 @@ def test_create_nightly_billing_consolidate_from_3_days_delta(
create_nightly_billing()
records = FactBilling.query.order_by(FactBilling.bst_date).all()
assert len(records) == 3
assert records[0].bst_date == date(2018, 1, 12)
assert len(records) == 10
assert records[0].bst_date == date(2018, 1, 5)
assert records[-1].bst_date == date(2018, 1, 14)