darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Steven Reilly <stvnrlly@users.noreply.github.com>
This commit is contained in:
Ryan Ahearn
2023-04-27 08:39:05 -04:00
committed by GitHub
parent 0ac1cd9e53
commit 4e6e06e41d
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/infra-overview.md
View File

@@ -117,7 +117,7 @@ This should be complete for all regions U.S. Notify has been deployed to or is c
1. Select `Toll-free registrations` and `Create registration` 1. Select `Toll-free registrations` and `Create registration`
1. Select the number you just created and then `Register existing toll-free number` 1. Select the number you just created and then `Register existing toll-free number`
1. Complete and submit the form. Approval usually takes about 2 weeks. 1. Complete and submit the form. Approval usually takes about 2 weeks.
1. See the run book for information on how to set those numbers. 1. See the [run book](./run-book.md) for information on how to set those numbers.
Example answers for toll-free registration form Example answers for toll-free registration form

4
docs/run-book.md
View File

@@ -91,7 +91,7 @@ Also known as: **How to move code from my machine to production**
### datagov-brokerpak-smtp ### datagov-brokerpak-smtp
1. To include new verisons of the SMTP borkerpak in released SSB code, create a PR in the `usnotify-ssb` repo updating the version in use in `app-setup-smtp.sh` 1. To include new verisons of the SMTP brokerpak in released SSB code, create a PR in the `usnotify-ssb` repo updating the version in use in `app-setup-smtp.sh`
### Vulnerability Mitigation Changes ### Vulnerability Mitigation Changes
@@ -157,7 +157,7 @@ Important policies:
| Role Name | System | Permissions | Notes | | Role Name | System | Permissions | Notes |
| --------- | ------ | ----------- | ----- | | --------- | ------ | ----------- | ----- |
| Cloud.gov Service Account | Cloud.gov | `OrgManager` and `SpaceDeveloper` | Creds stored in GitHub Environment secrets within api and admin app repos | | Cloud.gov Service Account | Cloud.gov | `OrgManager` and `SpaceDeveloper` | Creds stored in GitHub Environment secrets within api and admin app repos |
| SSB Deployment Account | AWS | `IAMFulLAccess` | Creds stored in GitHub Environment secrets within usnotify-ssb repo | | SSB Deployment Account | AWS | `IAMFullAccess` | Creds stored in GitHub Environment secrets within usnotify-ssb repo |
| SSB Cloud.gov Service Account | Cloud.gov | `SpaceDeveloper` | Creds stored in GitHub Environment secrets within usnotify-ssb repo | | SSB Cloud.gov Service Account | Cloud.gov | `SpaceDeveloper` | Creds stored in GitHub Environment secrets within usnotify-ssb repo |
| SSB AWS Accounts | AWS | `sms_broker` or `smtp_broker` IAM role | Creds created and maintained by usnotify-ssb terraform | | SSB AWS Accounts | AWS | `sms_broker` or `smtp_broker` IAM role | Creds created and maintained by usnotify-ssb terraform |