code review feedback

This commit is contained in:
Kenneth Kehl
2023-07-14 14:59:23 -07:00
parent e6077c187c
commit 4d090ed9ef
7 changed files with 125 additions and 60 deletions
@@ -7,6 +7,7 @@ Create Date: 2021-02-18 15:25:30.667098
"""
from alembic import op
import sqlalchemy as sa
from sqlalchemy import text
from sqlalchemy.dialects import postgresql
revision = '0348_migrate_broadcast_settings'
@@ -36,15 +37,20 @@ def upgrade():
for service in services:
input_params = {"service_id": service.id}
setting = conn.execute(
"SELECT service_id, channel, provider FROM service_broadcast_settings WHERE service_id=:service_id;",
text("SELECT service_id, channel, provider FROM service_broadcast_settings WHERE service_id=:service_id;"),
input_params).first()
if setting:
print(f"Service {service.id} already has service_broadcast_settings. No action required")
else:
channel = "severe" if service.restricted else "test"
print(f"Service {service.id} does not have service_broadcast_settings. Will insert one with channel {channel}")
conn.execute("INSERT INTO service_broadcast_settings (service_id, channel, created_at) VALUES (%s, %s, now());",
{service.id, channel})
input_params = {
"service_id": service.id,
"channel": channel
}
conn.execute(text("INSERT INTO service_broadcast_settings (service_id, channel, created_at) "
"VALUES (:service_id, :channel, now());"),
input_params)
def downgrade():