darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-22 00:11:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

The rstrip was not working for all file names so this changes it to a replace.

Browse Source
This commit is contained in:
Rebecca Law
2019-04-08 11:58:25 +01:00
parent 1ce044011c
commit 4ce2b9eaba
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/nightly_tasks.py
View File

@@ -295,14 +295,14 @@ def letter_raise_alert_if_no_ack_file_for_zip():
subfolder=today_str + '/zips_sent', subfolder=today_str + '/zips_sent',
suffix='.TXT'): suffix='.TXT'):
subname = key.split('/')[-1] # strip subfolder in name subname = key.split('/')[-1] # strip subfolder in name
zip_file_set.add(subname.upper().rstrip('ZIP.TXT')) zip_file_set.add(subname.upper().replace('.ZIP.TXT', ''))
# get acknowledgement file # get acknowledgement file
ack_file_set = set() ack_file_set = set()
for key in s3.get_list_of_files_by_suffix(bucket_name=current_app.config['DVLA_RESPONSE_BUCKET_NAME'], for key in s3.get_list_of_files_by_suffix(bucket_name=current_app.config['DVLA_RESPONSE_BUCKET_NAME'],
subfolder='root/dispatch', suffix='.ACK.txt', last_modified=yesterday): subfolder='root/dispatch', suffix='.ACK.txt', last_modified=yesterday):
ack_file_set.add(key.lstrip('root/dispatch').upper().rstrip('ACK.TXT')) ack_file_set.add(key.lstrip('root/dispatch').upper().replace('.ACK.TXT', ''))
message = ( message = (
"Letter ack file does not contain all zip files sent. " "Letter ack file does not contain all zip files sent. "

6
tests/app/celery/test_nightly_tasks.py
View File

@@ -57,10 +57,10 @@ def mock_s3_get_list_match(bucket_name, subfolder='', suffix='', last_modified=N
def mock_s3_get_list_diff(bucket_name, subfolder='', suffix='', last_modified=None): def mock_s3_get_list_diff(bucket_name, subfolder='', suffix='', last_modified=None):
if subfolder == '2018-01-11/zips_sent': if subfolder == '2018-01-11/zips_sent':
return ['NOTIFY.2018-01-11175007.ZIP.TXT', 'NOTIFY.2018-01-11175008.ZIP.TXT', 'NOTIFY.2018-01-11175009.ZIP.TXT', return ['NOTIFY.2018-01-11175007p.ZIP.TXT', 'NOTIFY.2018-01-11175008.ZIP.TXT',
'NOTIFY.2018-01-11175010.ZIP.TXT'] 'NOTIFY.2018-01-11175009.ZIP.TXT', 'NOTIFY.2018-01-11175010.ZIP.TXT']
if subfolder == 'root/dispatch': if subfolder == 'root/dispatch':
return ['root/disoatch/NOTIFY.2018-01-11175007.ACK.TXT', 'root/disoatch/NOTIFY.2018-01-11175008.ACK.TXT'] return ['root/disoatch/NOTIFY.2018-01-11175007p.ACK.TXT', 'root/disoatch/NOTIFY.2018-01-11175008.ACK.TXT']
@freeze_time('2016-10-18T10:00:00') @freeze_time('2016-10-18T10:00:00')