darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-11 02:23:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicate edge case test for monthly usage

Browse Source 
This doesn't change the structural behaviour of the API and can be
tested just as well at a lower level.
This commit is contained in:
Ben Thorner
2022-04-26 13:24:09 +01:00
parent ee4da698fe
commit 4cca01a8cb
2 changed files with 8 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/app/dao/test_ft_billing_dao.py
+7 -3
View File
@@ -484,14 +484,18 @@ def test_fetch_monthly_billing_for_year_variable_rates(notify_db_session):
@freeze_time('2018-08-01 13:30:00')
def test_fetch_monthly_billing_for_year_adds_data_for_today(notify_db_session):
service = create_service()
template = create_template(service=service, template_type="email")
template = create_template(service=service, template_type="sms")
create_rate(start_date=datetime.utcnow() - timedelta(days=1), value=0.158, notification_type='sms')
for i in range(1, 32):
create_ft_billing(bst_date='2018-07-{}'.format(i), template=template)
create_notification(template=template, status='delivered')
assert db.session.query(FactBilling.bst_date).count() == 31
results = fetch_monthly_billing_for_year(service_id=service.id,
year=2018)
results = fetch_monthly_billing_for_year(service_id=service.id, year=2018)
assert db.session.query(FactBilling.bst_date).count() == 32
assert len(results) == 2