darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-11 10:28:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use status_code in error response.

Browse Source 
Remove code.
This commit is contained in:
Rebecca Law
2016-11-02 14:58:39 +00:00
parent db91a87fb2
commit 4cb38e2d12
7 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/app/v2/notifications/test_notification_schemas.py
+3 -3
View File
@@ -32,7 +32,7 @@ def test_post_sms_json_schema_bad_uuid_and_missing_phone_number():
assert len(error.get('fields')) == 2
assert {"phone_number": "is a required property"} in error['fields']
assert {"template_id": "not a valid UUID"} in error['fields']
assert error.get('code') == '1001'
assert error.get('status_code') == 400
def test_post_sms_schema_with_personalisation_that_is_not_a_dict():
@@ -48,7 +48,7 @@ def test_post_sms_schema_with_personalisation_that_is_not_a_dict():
assert "POST v2/notifications/sms" in error['message']
assert len(error.get('fields')) == 1
assert error['fields'][0] == {"personalisation": "should contain key value pairs"}
assert error.get('code') == '1001'
assert error.get('status_code') == 400
valid_response = {
@@ -84,6 +84,6 @@ def test_post_sms_response_schema_missing_uri():
with pytest.raises(ValidationError) as e:
validate(j, post_sms_response)
error = json.loads(e.value.message)
assert '1001' == error['code']
assert error['status_code'] == 400
assert 'Validation error occurred - response v2/notifications/sms' == error['message']
assert [{"uri": "is a required property"}] == error['fields']