darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-04 12:18:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2025-02-10 11:05:41 -08:00
parent dae0f9cf6d 1cbd40f36b
commit 4a742a8873
9 changed files with 33 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/notifications_dao.py
View File

@@ -270,7 +270,6 @@ def get_notifications_for_job(
def get_recent_notifications_for_job(
service_id, job_id, filter_dict=None, page=1, page_size=None
):
print(f"FILTER_DICT AT DAO LEVEL {filter_dict}")
if page_size is None:
page_size = current_app.config["PAGE_SIZE"]
@@ -281,7 +280,6 @@ def get_recent_notifications_for_job(
stmt = _filter_query(stmt, filter_dict)
stmt = stmt.order_by(desc(Notification.job_row_number))
print(f"STMT {stmt}")
results = db.session.execute(stmt).scalars().all()
page_size = current_app.config["PAGE_SIZE"]