darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3359 from alphagov/improve-clarify-botocore-exception-180017131

Browse Source 
Improve and clarify large task error handling
This commit is contained in:
Ben Thorner
2021-11-12 11:10:17 +00:00
committed by GitHub
parent 850cdc16a0 1872854a4e
commit 4a577eca62
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/v2/notifications/post_notifications.py
View File

@@ -232,9 +232,10 @@ def process_sms_or_email_notification(
reply_to_text=reply_to_text
)
return resp
except botocore.exceptions.ClientError:
# if SQS cannot put the task on the queue, it's probably because the notification body was too long and it
# went over SQS's 256kb message limit. If so, we
except (botocore.exceptions.ClientError, botocore.parsers.ResponseParserError):
# If SQS cannot put the task on the queue, it's probably because the notification body was too long and it
# went over SQS's 256kb message limit. If the body is very large, it may exceed the HTTP max content length;
# the exception we get here isn't handled correctly by botocore - we get a ResponseParserError instead.
current_app.logger.info(
f'Notification {notification_id} failed to save to high volume queue. Using normal flow instead'
)