darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Change Organisation DAO update method

Browse Source 
- Changed the organisation DAO update method to only make 1 query
- Updated the update rest endpoint to not return an organisation when
the update is successful
This commit is contained in:
Katie Smith
2018-02-09 11:17:13 +00:00
parent 269923ba28
commit 4a14225d04
4 changed files with 27 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/organisation/rest.py
View File

@@ -6,7 +6,7 @@ from app.dao.organisation_dao import (
dao_get_organisation_by_id,
dao_update_organisation,
)
from app.errors import register_errors
from app.errors import register_errors, InvalidRequest
from app.models import Organisation
from app.organisation.organisation_schema import (
post_create_organisation_schema,
@@ -48,10 +48,10 @@ def create_organisation():
@organisation_blueprint.route('/<uuid:organisation_id>', methods=['POST'])
def update_organisation(organisation_id):
data = request.get_json()
validate(data, post_update_organisation_schema)
result = dao_update_organisation(organisation_id, **data)
fetched_organisation = dao_get_organisation_by_id(organisation_id)
dao_update_organisation(fetched_organisation, **data)
return jsonify(fetched_organisation.serialize()), 200
if result:
return '', 204
else:
raise InvalidRequest("Organisation not found", 404)