darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

use partial to make tests more legible

Browse Source
This commit is contained in:
Leo Hemsted
2016-10-11 14:40:23 +01:00
parent d8467bfc3c
commit 487554c025
1 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/app/dao/test_jobs_dao.py
View File

@@ -32,15 +32,15 @@ def test_should_get_all_statuses_for_notifications_associated_with_job(
notify_db_session, notify_db_session,
sample_service, sample_service,
sample_job): sample_job):
notification = partial(create_notification, notify_db, notify_db_session, service=sample_service, job=sample_job)
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='created') notification(status='created')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='sending') notification(status='sending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='delivered') notification(status='delivered')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='pending') notification(status='pending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='failed') notification(status='failed')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='technical-failure') # noqa notification(status='technical-failure')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='temporary-failure') # noqa notification(status='temporary-failure')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='permanent-failure') # noqa notification(status='permanent-failure')
results = dao_get_notification_outcomes_for_job(sample_service.id, sample_job.id) results = dao_get_notification_outcomes_for_job(sample_service.id, sample_job.id)
assert [(row.count, row.status) for row in results] == [ assert [(row.count, row.status) for row in results] == [
@@ -60,14 +60,15 @@ def test_should_count_of_statuses_for_notifications_associated_with_job(
notify_db_session, notify_db_session,
sample_service, sample_service,
sample_job): sample_job):
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='created') notification = partial(create_notification, notify_db, notify_db_session, service=sample_service, job=sample_job)
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='created') notification(status='created')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='sending') notification(status='created')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='sending') notification(status='sending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='sending') notification(status='sending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='sending') notification(status='sending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='delivered') notification(status='sending')
create_notification(notify_db, notify_db_session, service=sample_service, job=sample_job, status='delivered') notification(status='delivered')
notification(status='delivered')
results = dao_get_notification_outcomes_for_job(sample_service.id, sample_job.id) results = dao_get_notification_outcomes_for_job(sample_service.id, sample_job.id)
assert [(row.count, row.status) for row in results] == [ assert [(row.count, row.status) for row in results] == [