darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-11 09:27:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update the template_schema to include a parent_folder_id.

Browse Source 
When creating the Tempalte from_json, the folder is passed in. Since some validation should done, as in the folder exists and is for the same service, the folder is passed through to the Tempalte.from_json method.
When the template is persisted so is the relationship to folders.
TODO: If the folder is invalid a specific message should be returned.
This commit is contained in:
Rebecca Law
2018-11-05 10:54:42 +00:00
committed by Rebecca Law
parent 39198ed67e
commit 4849ecdf63
4 changed files with 71 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/template/rest.py
View File

@@ -29,7 +29,7 @@ from app.errors import (
InvalidRequest
)
from app.letters.utils import get_letter_pdf
from app.models import SMS_TYPE, Template
from app.models import SMS_TYPE, Template, TemplateFolder
from app.notifications.validators import service_has_permission, check_reply_to
from app.schema_validation import validate
from app.schemas import (template_schema, template_history_schema)
@@ -48,12 +48,19 @@ def _content_count_greater_than_limit(content, template_type):
return template.content_count > SMS_CHAR_COUNT_LIMIT
def validate_parent_folder(parent_folder_id, service_id):
return TemplateFolder.query.filter_by(service_id=service_id, id=parent_folder_id).one()
@template_blueprint.route('', methods=['POST'])
def create_template(service_id):
fetched_service = dao_fetch_service_by_id(service_id=service_id)
# permissions needs to be placed here otherwise marshmallow will interfere with versioning
permissions = fetched_service.permissions
new_template = Template.from_json(validate(request.get_json(), post_create_template_schema))
template_json = validate(request.get_json(), post_create_template_schema)
folder = validate_parent_folder(parent_folder_id=template_json['parent_folder_id'],
service_id=template_json['service'])
new_template = Template.from_json(template_json, folder)
if not service_has_permission(new_template.template_type, permissions):
message = "Creating {} templates is not allowed".format(
@@ -72,6 +79,7 @@ def create_template(service_id):
check_reply_to(service_id, new_template.reply_to, new_template.template_type)
dao_create_template(new_template)
return jsonify(data=template_schema.dump(new_template).data), 201

3
app/template/template_schemas.py
View File

@@ -16,7 +16,8 @@ post_create_template_schema = {
"process_type": {"emun": TEMPLATE_PROCESS_TYPE},
"content": {"type": "string"},
"subject": {"type": "string"},
"created_by": uuid
"created_by": uuid,
"parent_folder_id": uuid
},
"if": {
"properties": {