darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 10:21:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Move variable out of loop that didn't need to be

Browse Source
This commit is contained in:
David McDonald
2020-12-16 10:40:30 +00:00
parent 1bf9b29905
commit 47e146f010
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/dao/notifications_dao.py
View File

@@ -419,6 +419,7 @@ def _move_notifications_to_notification_history(notification_type, service_id, d
def _delete_letters_from_s3( def _delete_letters_from_s3(
notification_type, service_id, date_to_delete_from, query_limit notification_type, service_id, date_to_delete_from, query_limit
): ):
bucket_name = current_app.config['LETTERS_PDF_BUCKET_NAME']
letters_to_delete_from_s3 = db.session.query( letters_to_delete_from_s3 = db.session.query(
Notification Notification
).filter( ).filter(
@@ -427,7 +428,6 @@ def _delete_letters_from_s3(
Notification.service_id == service_id Notification.service_id == service_id
).limit(query_limit).all() ).limit(query_limit).all()
for letter in letters_to_delete_from_s3: for letter in letters_to_delete_from_s3:
bucket_name = current_app.config['LETTERS_PDF_BUCKET_NAME']
# although letters without a `sent_at` timestamp do have PDFs, they do not exist in the # although letters without a `sent_at` timestamp do have PDFs, they do not exist in the
# production-letters-pdf bucket as they never made it that far so we do not try and delete # production-letters-pdf bucket as they never made it that far so we do not try and delete
# them from it # them from it