darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 18:31:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix more skips

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-18 14:18:02 -07:00
parent 3c08670386
commit 47b5303726
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/app/dao/test_services_dao.py
View File

@@ -3,6 +3,7 @@ from datetime import datetime, timedelta
from unittest import mock from unittest import mock
import pytest import pytest
import sqlalchemy
from freezegun import freeze_time from freezegun import freeze_time
from sqlalchemy.exc import IntegrityError from sqlalchemy.exc import IntegrityError
from sqlalchemy.orm.exc import NoResultFound from sqlalchemy.orm.exc import NoResultFound
@@ -585,7 +586,7 @@ def test_update_service_permission_creates_a_history_record_with_current_data(no
assert history[2].version == 3 assert history[2].version == 3
@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason") # @pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason")
def test_create_service_and_history_is_transactional(notify_db_session): def test_create_service_and_history_is_transactional(notify_db_session):
user = create_user() user = create_user()
assert Service.query.count() == 0 assert Service.query.count() == 0
@@ -596,10 +597,11 @@ def test_create_service_and_history_is_transactional(notify_db_session):
restricted=False, restricted=False,
created_by=user) created_by=user)
with pytest.raises(IntegrityError) as excinfo: try:
dao_create_service(service, user) dao_create_service(service, user)
except sqlalchemy.exc.IntegrityError as seeei:
assert 'null value in column "name" of relation "services_history" violates not-null constraint' in str(seeei)
assert 'column "name" violates not-null constraint' in str(excinfo.value)
assert Service.query.count() == 0 assert Service.query.count() == 0
assert Service.get_history_model().query.count() == 0 assert Service.get_history_model().query.count() == 0

1
tests/app/user/test_rest_verify.py
View File

@@ -292,7 +292,6 @@ def test_send_sms_code_returns_204_when_too_many_codes_already_created(client, s
assert VerifyCode.query.count() == 5 assert VerifyCode.query.count() == 5
@pytest.mark.skip(reason="Needs updating for TTS: Failing for unknown reason")
@pytest.mark.parametrize('post_data, expected_url_starts_with', ( @pytest.mark.parametrize('post_data, expected_url_starts_with', (
( (
{}, {},