mirror of
https://github.com/GSA/notifications-api.git
synced 2026-08-14 23:07:49 -04:00
Make international SMS on for new services
International SMS is a mature, documented feature now. There’s no reason it shouldn’t be available to everyone. If it’s turned off by default then we’re relying on people finding it in the settings page to know that it exists (which we found in research the other week that users, who would have benefitted from having international SMS, were failing to do). This also fixes the problem whereby users signing up for Notify with an international phone number (eg those working abroad for the Foreign and Commonwealth Office) couldn’t get through the tour because they weren’t able to send themselves the example text message (see https://www.pivotaltracker.com/story/show/150705515).
This commit is contained in:
@@ -203,7 +203,14 @@ def test_get_service_list_has_default_permissions(client, service_factory):
|
||||
assert response.status_code == 200
|
||||
json_resp = json.loads(response.get_data(as_text=True))
|
||||
assert len(json_resp['data']) == 3
|
||||
assert all([set(json['permissions']) == set([EMAIL_TYPE, SMS_TYPE]) for json in json_resp['data']])
|
||||
assert all(
|
||||
set(
|
||||
json['permissions']
|
||||
) == set([
|
||||
EMAIL_TYPE, SMS_TYPE, INTERNATIONAL_SMS_TYPE,
|
||||
])
|
||||
for json in json_resp['data']
|
||||
)
|
||||
|
||||
|
||||
def test_get_service_by_id_has_default_service_permissions(client, sample_service):
|
||||
@@ -214,7 +221,11 @@ def test_get_service_by_id_has_default_service_permissions(client, sample_servic
|
||||
)
|
||||
json_resp = json.loads(resp.get_data(as_text=True))
|
||||
|
||||
assert set(json_resp['data']['permissions']) == set([EMAIL_TYPE, SMS_TYPE])
|
||||
assert set(
|
||||
json_resp['data']['permissions']
|
||||
) == set([
|
||||
EMAIL_TYPE, SMS_TYPE, INTERNATIONAL_SMS_TYPE,
|
||||
])
|
||||
|
||||
|
||||
def test_get_service_by_id_should_404_if_no_service(notify_api, notify_db):
|
||||
|
||||
Reference in New Issue
Block a user