darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 02:41:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor process_ses_receipt

Browse Source 
It is possible a service has data rention that is smaller than the time it takes to get a delivery receipt.
This PR refactors process_ses_receipt to update NotificationHistory if the Notifcation has already been purged.
This commit is contained in:
Rebecca Law
2020-03-27 14:12:39 +00:00
parent 8da73510c2
commit 46b72a6bbb
4 changed files with 28 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1567,7 +1567,9 @@ def test_dao_update_notifications_by_reference_set_returned_letter_status(sample
assert updated_count == 1
assert updated_history_count == 0
assert Notification.query.get(notification.id).status == 'returned-letter'
updated_notification = Notification.query.get(notification.id)
assert updated_notification.status == 'returned-letter'
assert updated_notification.updated_at <= datetime.utcnow()
def test_dao_update_notifications_by_reference_updates_history_when_one_of_two_notifications_exists(