diff --git a/migrations/versions/0135_sms_sender_nullable.py b/migrations/versions/0137_sms_sender_nullable.py similarity index 93% rename from migrations/versions/0135_sms_sender_nullable.py rename to migrations/versions/0137_sms_sender_nullable.py index 61818b26a..93e8e01a2 100644 --- a/migrations/versions/0135_sms_sender_nullable.py +++ b/migrations/versions/0137_sms_sender_nullable.py @@ -1,7 +1,7 @@ """ -Revision ID: 0135_sms_sender_nullable -Revises: 0134_add_email_2fa_template +Revision ID: 0137_sms_sender_nullable +Revises: 0136_user_mobile_nullable Create Date: 2017-11-06 15:44:59.471977 """ @@ -9,8 +9,8 @@ from alembic import op import sqlalchemy as sa from sqlalchemy.dialects import postgresql -revision = '0135_sms_sender_nullable' -down_revision = '0134_add_email_2fa_template' +revision = '0137_sms_sender_nullable' +down_revision = '0136_user_mobile_nullable' def upgrade(): diff --git a/tests/app/db.py b/tests/app/db.py index 798cf5e6e..4049486fc 100644 --- a/tests/app/db.py +++ b/tests/app/db.py @@ -89,29 +89,9 @@ def create_service( def create_service_with_inbound_number( inbound_number='1234567', - user=None, - service_name="Sample service", - service_id=None, - restricted=False, - service_permissions=[EMAIL_TYPE, SMS_TYPE], - research_mode=False, - active=True, - email_from=None, - prefix_sms=None + *args, **kwargs ): - service = Service( - name=service_name, - message_limit=1000, - restricted=restricted, - email_from=email_from if email_from else service_name.lower().replace(' ', '.'), - created_by=user or create_user(email='{}@digital.cabinet-office.gov.uk'.format(uuid.uuid4())), - prefix_sms=prefix_sms, - ) - - dao_create_service(service, service.created_by, service_id, service_permissions=service_permissions) - - service.active = active - service.research_mode = research_mode + service = create_service(*args, **kwargs) sms_sender = ServiceSmsSender.query.filter_by(service_id=service.id).first() inbound = create_inbound_number(number=inbound_number, service_id=service.id) diff --git a/tests/app/service/test_rest.py b/tests/app/service/test_rest.py index 46cc2ae7c..8902587d6 100644 --- a/tests/app/service/test_rest.py +++ b/tests/app/service/test_rest.py @@ -35,8 +35,7 @@ from tests.app.db import ( create_letter_contact, create_inbound_number, create_service_sms_sender, - create_service_with_defined_sms_sender, - create_service_with_inbound_number + create_service_with_defined_sms_sender ) from tests.app.db import create_user from app.dao.date_util import get_current_financial_year_start_year