darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Delete job-stats endpoints

Browse Source 
Deleted these endpoints:
* /service/<uuid:service_id>/job-stats/<job_id>
* /service/<uuid:service_id>/job-stats
This commit is contained in:
Katie Smith
2018-03-05 16:17:56 +00:00
parent 4f7dd1d258
commit 44c4026df2
2 changed files with 1 additions and 149 deletions
Download Patch File Download Diff File Expand all files Collapse all files

87
tests/app/job/test_rest.py
View File

@@ -6,7 +6,6 @@ from freezegun import freeze_time
import pytest
import pytz
import app.celery.tasks
from app import DATETIME_FORMAT
from tests import create_authorization_header
from tests.conftest import set_config
@@ -769,89 +768,3 @@ def test_get_all_notifications_for_job_returns_csv_format(
notification = resp['notifications'][0]
assert set(notification.keys()) == \
set(['created_at', 'template_type', 'template_name', 'job_name', 'status', 'row_number', 'recipient'])
# New endpoint to get job statistics the old tests will be refactored away.
def test_get_jobs_for_service_new_endpoint(client, notify_db, notify_db_session, sample_template):
_setup_jobs(notify_db, notify_db_session, sample_template)
service_id = sample_template.service.id
path = '/service/{}/job/job-stats'.format(service_id)
auth_header = create_authorization_header()
response = client.get(path, headers=[auth_header])
assert response.status_code == 200
resp_json = json.loads(response.get_data(as_text=True))
assert len(resp_json['data']) == 5
assert resp_json['data'][0]["job_id"]
assert resp_json['data'][0]["created_at"]
assert not resp_json['data'][0]["scheduled_for"]
assert resp_json['data'][0]["template_id"]
assert resp_json['data'][0]["template_version"]
assert resp_json['data'][0]["service_id"]
assert resp_json['data'][0]["requested"]
assert resp_json['data'][0]["sent"] == 0
assert resp_json['data'][0]["delivered"] == 0
assert resp_json['data'][0]["failed"] == 0
def test_get_jobs_raises_for_bad_limit_days(client, sample_service):
path = '/service/{}/job/job-stats'.format(sample_service.id)
auth_header = create_authorization_header()
response = client.get(path,
query_string={'limit_days': 'bad_number'},
headers=[auth_header])
assert response.status_code == 400
resp_json = json.loads(response.get_data(as_text=True))
assert resp_json["result"] == "error"
assert resp_json["message"] == {'limit_days': ['bad_number is not an integer']}
def test_parse_status_turns_comma_sep_strings_into_list():
statuses = "started, finished, pending"
from app.job.rest import _parse_statuses
assert _parse_statuses(statuses) == ["started", "finished", "pending"]
def test_parse_status_turns_empty_string_into_empty_list():
statuses = ""
from app.job.rest import _parse_statuses
assert _parse_statuses(statuses) == ['']
def test_get_job_stats_by_service_id_and_job_id(client, sample_job):
auth_header = create_authorization_header()
response = client.get("/service/{}/job/job-stats/{}".format(sample_job.service_id, sample_job.id),
headers=[auth_header])
assert response.status_code == 200
resp_json = json.loads(response.get_data(as_text=True))
assert resp_json["job_id"] == str(sample_job.id)
assert resp_json["created_at"] == sample_job.created_at.strftime(DATETIME_FORMAT)
assert not resp_json["scheduled_for"]
assert resp_json["template_id"] == str(sample_job.template_id)
assert resp_json["template_version"] == sample_job.template_version
assert resp_json["service_id"] == str(sample_job.service_id)
assert resp_json["requested"] == sample_job.notification_count
assert resp_json["sent"] == 0
assert resp_json["delivered"] == 0
assert resp_json["failed"] == 0
def test_get_job_stats_with_invalid_job_id_returns404(client, sample_template):
path = '/service/{}/job/job-stats/{}'.format(sample_template.service.id, uuid.uuid4())
auth_header = create_authorization_header()
response = client.get(path, headers=[auth_header])
assert response.status_code == 404
resp_json = json.loads(response.get_data(as_text=True))
assert resp_json['result'] == 'error'
assert resp_json['message'] == 'No result found'
def test_get_job_stats_with_invalid_service_id_returns404(client, sample_job):
path = '/service/{}/job/job-stats/{}'.format(uuid.uuid4(), sample_job.id)
auth_header = create_authorization_header()
response = client.get(path, headers=[auth_header])
assert response.status_code == 404
resp_json = json.loads(response.get_data(as_text=True))
assert resp_json['result'] == 'error'
assert resp_json['message'] == 'No result found'