darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removed the updates to the job table to track delivery of notifications

Browse Source 
Previously we kept a running total of job progress/success/failure on the job table. This causes contention, we now generate this data from notification history.

Removed these updates.
This commit is contained in:
Martyn Inglis
2016-08-25 09:29:53 +01:00
parent 020d998baa
commit 44bc071037
3 changed files with 0 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/app/celery/test_provider_tasks.py
View File

@@ -328,9 +328,6 @@ def test_should_go_into_technical_error_if_exceeds_retries(
notification_stats = NotificationStatistics.query.filter_by(service_id=notification.service.id).first()
assert notification_stats.sms_requested == 1
assert notification_stats.sms_failed == 1
job = Job.query.get(notification.job.id)
assert job.notification_count == 1
assert job.notifications_failed == 1
def test_should_send_sms_sender_from_service_if_present(
@@ -442,9 +439,6 @@ def test_send_email_to_provider_should_go_into_technical_error_if_exceeds_retrie
notification_stats = NotificationStatistics.query.filter_by(service_id=notification.service.id).first()
assert notification_stats.emails_requested == 1
assert notification_stats.emails_failed == 1
job = Job.query.get(notification.job.id)
assert job.notification_count == 1
assert job.notifications_failed == 1
def test_send_email_to_provider_should_not_send_to_provider_when_status_is_not_created(notify_db, notify_db_session,