darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-18 07:11:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update error message for password to match marshmallow errors.

Browse Source
This commit is contained in:
Adam Shimali
2016-01-19 12:07:14 +00:00
parent f839bae1f5
commit 44824c9985
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/user/rest.py
View File

@@ -19,7 +19,8 @@ def create_user():
user, errors = user_schema.load(request.get_json()) user, errors = user_schema.load(request.get_json())
req_json = request.get_json() req_json = request.get_json()
if not req_json.get('password'): if not req_json.get('password'):
return jsonify(result="error", message={'error': 'password missing'}), 400 errors = {'password': ['Missing data for required field.']}
return jsonify(result="error", message=errors), 400
if errors: if errors:
return jsonify(result="error", message=errors), 400 return jsonify(result="error", message=errors), 400
@@ -41,6 +42,8 @@ def update_user(user_id):
status_code = 202 status_code = 202
delete_model_user(user) delete_model_user(user)
else: else:
# TODO removed some validation checking by using load
# which will need to be done in another way
status_code = 200 status_code = 200
db.session.rollback() db.session.rollback()
save_model_user(user, update_dict=request.get_json()) save_model_user(user, update_dict=request.get_json())

2
tests/app/user/test_rest.py
View File

@@ -152,7 +152,7 @@ def test_post_user_missing_attribute_password(notify_api, notify_db, notify_db_s
assert resp.status_code == 400 assert resp.status_code == 400
assert User.query.count() == 1 assert User.query.count() == 1
json_resp = json.loads(resp.get_data(as_text=True)) json_resp = json.loads(resp.get_data(as_text=True))
assert {'error': 'password missing'} == json_resp['message'] assert {'password': ['Missing data for required field.']} == json_resp['message']
def test_put_user(notify_api, notify_db, notify_db_session, sample_user, sample_admin_service_id): def test_put_user(notify_api, notify_db, notify_db_session, sample_user, sample_admin_service_id):