clean up and remove redundancy

tests/app/db.py

@@ -566,7 +566,7 @@ def create_api_key(service, key_type=KEY_TYPE_NORMAL, key_name=None):
     return api_key
 
 
-def create_inbound_number(number, provider='mmg', active=True, service_id=None):
+def create_inbound_number(number, provider='sns', active=True, service_id=None):
     inbound_number = InboundNumber(
         id=uuid.uuid4(),
         number=number,

tests/app/test_schemas.py

@@ -106,7 +106,7 @@ def test_provider_details_schema_returns_user_details(
     restore_provider_details
 ):
     from app.schemas import provider_details_schema
-    current_sms_provider = get_provider_details_by_identifier('mmg')
+    current_sms_provider = get_provider_details_by_identifier('sns')
     current_sms_provider.created_by = sample_user
     data = provider_details_schema.dump(current_sms_provider)
 
@@ -119,7 +119,7 @@ def test_provider_details_history_schema_returns_user_details(
     restore_provider_details,
 ):
     from app.schemas import provider_details_schema
-    current_sms_provider = get_provider_details_by_identifier('mmg')
+    current_sms_provider = get_provider_details_by_identifier('sns')
     current_sms_provider.created_by_id = sample_user.id
     data = provider_details_schema.dump(current_sms_provider)
 

tests/test_all_queues_used.py

@@ -1,6 +1,7 @@
 from app.config import QueueNames
 
 
+# NOTE 100422 pass_app_wrapper can probably be removed
 def test_queue_names_set_in_paas_app_wrapper():
     with open("scripts/paas_app_wrapper.sh", 'r') as stream:
         search = ' -Q '