Fix missing import on notification stats endpoint

The response import was missing, which broke things.

There was no test to catch this.

This commit adds a rudimentary test to make sure that the endpoint
doesn’t 500, at the very least.
This commit is contained in:
Chris Hill-Scott
2016-04-20 10:33:41 +01:00
parent 85d5c656f8
commit 425cc8340e
2 changed files with 26 additions and 0 deletions

View File

@@ -1,6 +1,7 @@
from flask import ( from flask import (
Blueprint, Blueprint,
jsonify, jsonify,
request
) )
from app.dao.notifications_dao import ( from app.dao.notifications_dao import (

View File

@@ -492,6 +492,31 @@ def test_filter_by_status_and_template_type(notify_api,
assert response.status_code == 200 assert response.status_code == 200
def test_get_notification_statistics(
notify_api,
notify_db,
notify_db_session,
sample_template,
sample_email_template
):
with notify_api.test_request_context():
with notify_api.test_client() as client:
path = '/service/{}/notifications-statistics'.format(sample_email_template.service)
auth_header = create_authorization_header(
service_id=sample_email_template.service_id,
path=path,
method='GET')
response = client.get(path, headers=[auth_header])
assert response.status_code == 404
stats = json.loads(response.get_data(as_text=True))
assert stats['result'] == 'error'
assert stats['message'] == 'No result found'
def test_create_sms_should_reject_if_missing_required_fields(notify_api, sample_api_key, mocker): def test_create_sms_should_reject_if_missing_required_fields(notify_api, sample_api_key, mocker):
with notify_api.test_request_context(): with notify_api.test_request_context():
with notify_api.test_client() as client: with notify_api.test_client() as client: