darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-24 16:23:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make the update template endpoint work when process_type is present.

Browse Source
This commit is contained in:
Rebecca Law
2017-01-17 15:48:51 +00:00
parent e360a1f8f6
commit 41b49eb8e0
3 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/schemas.py
View File

@@ -208,6 +208,7 @@ class BaseTemplateSchema(BaseSchema):
class TemplateSchema(BaseTemplateSchema): class TemplateSchema(BaseTemplateSchema):
created_by = field_for(models.Template, 'created_by', required=True) created_by = field_for(models.Template, 'created_by', required=True)
process_type = field_for(models.Template, 'process_type')
@validates_schema @validates_schema
def validate_type(self, data): def validate_type(self, data):

2
app/template/rest.py
View File

@@ -144,5 +144,5 @@ def _strip_html(content):
def _template_has_not_changed(current_data, updated_template): def _template_has_not_changed(current_data, updated_template):
return all( return all(
current_data[key] == updated_template[key] current_data[key] == updated_template[key]
for key in ('name', 'content', 'subject', 'archived') for key in ('name', 'content', 'subject', 'archived', 'process_type')
) )

22
tests/app/template/test_rest.py
View File

@@ -1,4 +1,3 @@
import pytest
import json import json
import random import random
import string import string
@@ -42,11 +41,17 @@ def test_should_create_a_new_template_for_a_service(
assert json_resp['data']['service'] == str(sample_service.id) assert json_resp['data']['service'] == str(sample_service.id)
assert json_resp['data']['id'] assert json_resp['data']['id']
assert json_resp['data']['version'] == 1 assert json_resp['data']['version'] == 1
assert json_resp['data']['process_type'] == 'normal'
assert json_resp['data']['created_by'] == str(sample_user.id)
if subject: if subject:
assert json_resp['data']['subject'] == 'subject' assert json_resp['data']['subject'] == 'subject'
else: else:
assert not json_resp['data']['subject'] assert not json_resp['data']['subject']
template = Template.query.get(json_resp['data']['id'])
from app.schemas import template_schema
assert sorted(json_resp['data']) == sorted(template_schema.dump(template).data)
def test_should_be_error_if_service_does_not_exist_on_create(client, sample_user, fake_uuid): def test_should_be_error_if_service_does_not_exist_on_create(client, sample_user, fake_uuid):
data = { data = {
@@ -335,6 +340,7 @@ def test_should_get_a_single_template(
assert response.status_code == 200 assert response.status_code == 200
assert data['content'] == content assert data['content'] == content
assert data['subject'] == subject assert data['subject'] == subject
assert data['process_type'] == 'normal'
@pytest.mark.parametrize( @pytest.mark.parametrize(
@@ -516,3 +522,17 @@ def test_update_does_not_create_new_version_when_there_is_no_change(client, samp
template = dao_get_template_by_id(sample_template.id) template = dao_get_template_by_id(sample_template.id)
assert template.version == 1 assert template.version == 1
def test_update_set_process_type_on_template(client, sample_template):
auth_header = create_authorization_header()
data = {
'process_type': 'priority'
}
resp = client.post('/service/{}/template/{}'.format(sample_template.service_id, sample_template.id),
data=json.dumps(data),
headers=[('Content-Type', 'application/json'), auth_header])
assert resp.status_code == 200
template = dao_get_template_by_id(sample_template.id)
assert template.process_type == 'priority'