darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 06:52:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

add tests

Browse Source
This commit is contained in:
Leo Hemsted
2018-08-24 15:12:02 +01:00
parent 001f84b0b8
commit 40c537a9f5
4 changed files with 81 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/celery/letters_pdf_tasks.py
View File

@@ -7,7 +7,7 @@ from requests import (
post as requests_post,
RequestException
)
from celery.exceptions import MaxRetriesExceededError
from notifications_utils.statsd_decorators import statsd
from notifications_utils.s3 import s3upload
@@ -70,7 +70,7 @@ def create_letters_pdf(self, notification_id):
"Letters PDF notification creation for id: {} failed".format(notification_id)
)
self.retry(queue=QueueNames.RETRY)
except self.MaxRetriesExceededError:
except MaxRetriesExceededError:
current_app.logger.exception(
"RETRY FAILED: task create_letters_pdf failed for notification {}".format(notification_id),
)
@@ -228,7 +228,7 @@ def _sanitise_precomiled_pdf(self, notification, precompiled_pdf):
resp.raise_for_status()
return resp.content
except RequestException as ex:
if ex.status_code == 400:
if ex.response is not None and ex.response.status_code == 400:
# validation error
return None
@@ -237,7 +237,7 @@ def _sanitise_precomiled_pdf(self, notification, precompiled_pdf):
"sanitise_precomiled_pdf failed for notification: {}".format(notification.id)
)
self.retry(queue=QueueNames.RETRY)
except self.MaxRetriesExceededError:
except MaxRetriesExceededError:
current_app.logger.exception(
"RETRY FAILED: sanitise_precomiled_pdf failed for notification {}".format(notification.id),
)