darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 01:41:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

allow broadcasts to have a template and no content

Browse Source 
ensures code remains backwards compatible during the deploy. this commit
should be reverted once all broadcast_message.content fields have been
back-filled.
This commit is contained in:
Leo Hemsted
2021-01-11 15:56:40 +00:00
parent 91abe6d55f
commit 400dfe0217
2 changed files with 46 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/app/broadcast_message/test_rest.py
View File

@@ -477,6 +477,43 @@ def test_update_broadcast_message_status_creates_event_with_correct_content_if_b
assert alert_event.transmitted_content == {"body": "tailor made emergency broadcast content"}
# TODO: Remove this unit test after broadcast message content is guaranteed to always be populated.
def test_update_broadcast_message_status_creates_event_with_correct_content_if_broadcast_has_no_content_field(
admin_request,
sample_broadcast_service,
mocker
):
t = create_template(sample_broadcast_service, BROADCAST_TYPE, content='emergency broadcast')
bm = create_broadcast_message(
t,
status=BroadcastStatusType.PENDING_APPROVAL,
areas={"areas": ["london"], "simple_polygons": [[[51.30, 0.7], [51.28, 0.8], [51.25, -0.7]]]}
)
# simulate having no content because the broadcast message was created before migration 0335 came in
bm.content = None
approver = create_user(email='approver@gov.uk')
sample_broadcast_service.users.append(approver)
mock_task = mocker.patch('app.celery.broadcast_message_tasks.send_broadcast_event.apply_async')
response = admin_request.post(
'broadcast_message.update_broadcast_message_status',
_data={'status': BroadcastStatusType.BROADCASTING, 'created_by': str(approver.id)},
service_id=t.service_id,
broadcast_message_id=bm.id,
_expected_status=200
)
assert response['status'] == BroadcastStatusType.BROADCASTING
assert len(bm.events) == 1
alert_event = bm.events[0]
mock_task.assert_called_once_with(kwargs={'broadcast_event_id': str(alert_event.id)}, queue='notify-internal-tasks')
assert alert_event.transmitted_content == {"body": "emergency broadcast"}
def test_update_broadcast_message_status_rejects_approval_from_creator(
admin_request,
sample_broadcast_service,