diff --git a/app/clients/__init__.py b/app/clients/__init__.py index c6b620517..7ab453318 100644 --- a/app/clients/__init__.py +++ b/app/clients/__init__.py @@ -1,3 +1,5 @@ +from typing import Protocol + from botocore.config import Config AWS_CLIENT_CONFIG = Config( @@ -22,7 +24,7 @@ class ClientException(Exception): pass -class Client(object): +class Client(Protocol): """ Base client for sending notifications. """ diff --git a/app/clients/email/__init__.py b/app/clients/email/__init__.py index 7a2f710a3..1855308b5 100644 --- a/app/clients/email/__init__.py +++ b/app/clients/email/__init__.py @@ -1,3 +1,5 @@ +from abc import abstractmethod, abstractproperty + from app.clients import Client, ClientException @@ -27,9 +29,10 @@ class EmailClient(Client): Base Email client for sending emails. """ + @abstractmethod def send_email(self, *args, **kwargs): raise NotImplementedError("TODO Need to implement.") - @property + @abstractproperty def name(self): raise NotImplementedError("TODO Need to implement.") diff --git a/app/clients/pinpoint/__init__.py b/app/clients/pinpoint/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/clients/sms/__init__.py b/app/clients/sms/__init__.py index 2e7f27cdc..cd4ca57a7 100644 --- a/app/clients/sms/__init__.py +++ b/app/clients/sms/__init__.py @@ -1,3 +1,5 @@ +from abc import abstractmethod + from app.clients import Client, ClientException @@ -18,11 +20,14 @@ class SmsClient(Client): Base Sms client for sending smss. """ + @abstractmethod def init_app(self, *args, **kwargs): raise NotImplementedError("TODO Need to implement.") + @abstractmethod def send_sms(self, *args, **kwargs): raise NotImplementedError("TODO Need to implement.") + @abstractmethod def get_name(self): raise NotImplementedError("TODO Need to implement.") diff --git a/migrations/versions/0409_fix_service_name.py b/migrations/versions/0409_fix_service_name.py index 04c6ba359..6c90b65ce 100644 --- a/migrations/versions/0409_fix_service_name.py +++ b/migrations/versions/0409_fix_service_name.py @@ -27,7 +27,8 @@ def upgrade(): # select_by_val = service_id input_params = {"service_id": service_id} conn.execute( - text("update services set name='Notify.gov' where id =:service_id"), input_params + text("update services set name='Notify.gov' where id =:service_id"), + input_params, ) # table_name = 'services_history'