darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-04 02:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add error handling for possible string/datetime created at stamps

Browse Source
This commit is contained in:
Andrew Shumway
2025-01-15 12:49:47 -07:00
parent 345ae88ffc
commit 3fd8009e33
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/dao/notifications_dao.py
View File

@@ -103,8 +103,19 @@ def dao_create_notification(notification):
orig_time = notification.created_at orig_time = notification.created_at
now_time = utc_now() now_time = utc_now()
print(hilite(f"original time: {orig_time} - {type(orig_time)} \n now time: {now_time} - {type(now_time)}")) print(
diff_time = now_time - datetime.strptime(orig_time, "%Y-%m-%D-%H-%M-%S") hilite(
f"original time: {orig_time} - {type(orig_time)} \n now time: {now_time} - {type(now_time)}"
)
)
try:
diff_time = now_time - orig_time
except TypeError:
try:
orig_time = datetime.strptime(orig_time, "%Y-%m-%dT%H:%M:%S.%fZ")
except ValueError:
orig_time = datetime.strptime(orig_time, "%Y-%m-%d")
diff_time = now_time - orig_time
current_app.logger.error( current_app.logger.error(
f"dao_create_notification orig created at: {orig_time} and now created at: {now_time}" f"dao_create_notification orig created at: {orig_time} and now created at: {now_time}"
) )

1
tests/app/celery/test_reporting_tasks.py
View File

@@ -103,7 +103,6 @@ def test_create_nightly_notification_status_triggers_relevant_tasks(
mock_celery = mocker.patch( mock_celery = mocker.patch(
"app.celery.reporting_tasks.create_nightly_notification_status_for_service_and_day" "app.celery.reporting_tasks.create_nightly_notification_status_for_service_and_day"
).apply_async ).apply_async
for notification_type in NotificationType: for notification_type in NotificationType:
template = create_template(sample_service, template_type=notification_type) template = create_template(sample_service, template_type=notification_type)
create_notification(template=template, created_at=notification_date) create_notification(template=template, created_at=notification_date)